gettingstarted: Update with our code review policy. Change-Id: Ib73005d1734f91f98e73dc5d09171968dbaf9181
diff --git a/GettingStarted.md b/GettingStarted.md index 202cd41..c2b056f 100644 --- a/GettingStarted.md +++ b/GettingStarted.md
@@ -82,6 +82,47 @@ For more information on how to use repo and git effectively, take a look at the [official documentation](https://source.android.com/setup/create/coding-tasks). +### A Note on Code Review Policies + +In the Shodan project, we follow a "sticky +2" policy. + +What this means is that you *must* get a +2 Code Review from a peer, or a TL. +Gerrit will automatically remove any +2 Code Review scores you receive when you +upload a patchset. In this case, once a peer has given you a +2 Code Review, you +are free to re-+2 your change yourself if the changes are minor or otherwise +address comments in the CL. + +If you change significant parts of the CL post-+2, please ask for additional +review from your peers in a reply. Note: two +1s does *not* count as a +2! + +You may *not* self-+2 your own CLs, no matter the urgency or how simple the +change is! Resist the temptation! This policy is in place so that we can quickly +get through code review and get our code submitted without requiring lots of +round-trips with your reviewers. + +Please don't abuse this policy and use good judgement: if you don't know who to +send a CL to, put one of the TLs on the review list, and they'll redirect it +appropriately, or review your change. If we abuse the policy by +2-ing before +peer review, this privilige will unfortunately have to be revoked, slowing down +the entire team in the process, and possibly getting yourself in trouble with +security/compliance. + +### Who are the TLs? + +At the time of this writing, the TLs are: + +Cindy Liu <hcindyl@> +June Tate-Gans <jtgans@> +Bangfei Pan <pbf@> +Steve Xu <stevexu@> + +Finally, if you can't get one of the above people, please put Kai Yick +<kingkai@> on the review line. + +*Special note if you're listed above*: you still must get your +2 from someone +else -- we need the TLs to lead by example and demonstrate the appropriate +behavior. + ### How to sync my local copy with latest? ```bash