Merge pull request #215 from jrvanwhy/code-review
Add a code review policy
diff --git a/.travis.yml b/.travis.yml
index 52e5d38..2333df3 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -14,7 +14,8 @@
cache: cargo
install:
- - make -j8 setup
+ - CI=y make -j8 setup
+ - rm -rf ~/opentitan* # Make sure this isn't left over, see https://github.com/tock/tock/pull/1978
script:
- make test
diff --git a/Makefile b/Makefile
index 5218010..b7efed7 100644
--- a/Makefile
+++ b/Makefile
@@ -49,7 +49,7 @@
# patches to better support boards that Tock supports.
.PHONY: setup-qemu
setup-qemu:
- $(MAKE) -C tock emulation-setup
+ CI=true $(MAKE) -C tock ci-setup-qemu
# Builds a Tock kernel for the HiFive board for use by QEMU tests.
.PHONY: kernel-hifive
@@ -64,7 +64,7 @@
# Runs the libtock_test tests in QEMU on a simulated HiFive board.
.PHONY: test-qemu-hifive
-test-qemu-hifive: kernel-hifive setup-qemu
+test-qemu-hifive: kernel-hifive
PLATFORM=hifive1 cargo rrv32imac --example libtock_test --features=alloc \
--features=__internal_disable_gpio_in_integration_test
cargo run -p test_runner
diff --git a/boards/layout_opentitan.ld b/boards/layout_opentitan.ld
index 0ae4b60..95b801d 100644
--- a/boards/layout_opentitan.ld
+++ b/boards/layout_opentitan.ld
@@ -10,7 +10,7 @@
* the kernel binary, check for the actual address of APP_MEMORY!
*/
FLASH (rx) : ORIGIN = 0x20030040, LENGTH = 32M
- SRAM (rwx) : ORIGIN = 0x10002D00, LENGTH = 512K
+ SRAM (rwx) : ORIGIN = 0x10003000, LENGTH = 512K
}
/*
diff --git a/examples/hello_world.rs b/examples/hello_world.rs
index 4a67404..052cf69 100644
--- a/examples/hello_world.rs
+++ b/examples/hello_world.rs
@@ -1,4 +1,6 @@
// This example just prints "Hello Tock World" to the terminal.
+// Run `tockloader listen`, or use any serial program of your choice
+// (e.g. `screen`, `minicom`) to view the message.
#![no_std]
diff --git a/tock b/tock
index 152189f..957a890 160000
--- a/tock
+++ b/tock
@@ -1 +1 @@
-Subproject commit 152189fe077aea955332ee3c28ccbee519d8b072
+Subproject commit 957a890e97550db00ca38407d93d2896d2724ec5
