commit e96e3c004011550c6b4ecc1520e0f022984c4b17
author Stanley Winata <68087699+raikonenfnu@users.noreply.github.com> Thu Oct 24 16:56:38 2024 -0700
committer GitHub <noreply@github.com> Thu Oct 24 16:56:38 2024 -0700
tree 7789c2739d0ba2b030ccb617d06ad5d230567dee
parent aef6e1fc8fe85f4a57bc06b0272ada18975494fb

[VectorLayout] Fix insertion of new constOp for non dominate issue. (#18894)

Main motivation of this patch is to resolve issue where we have the same
constOp being used by multiple operations.

But with a twist where first time the constOp needs a layout is on a op
that topologically comes after other ops that use constOp. This will
generate a copy of constOp in the location right before the latter op,
which is problematic because this constOp will be used by other ops
before it.

Previously for the test added we get this error:
```
within split at contraction_layout.mlir:1 offset :24:10: note: see current operation: %9 = "arith.addf"(%8, %6) <{fastmath = #arith.fastmath<none>}> : (vector<96x64xf16>, vector<96x64xf16>) -> vector<96x64xf16>
within split at contraction_layout.mlir:1 offset :22:19: error: operand #1 does not dominate this use
    %scaled_rhs = arith.mulf %read_1, %cst_1 : vector<96x64xf16>
```

While minor, this is also problematic because this error seem to stopped
layout analysis (but not fatally) S.T it fails to vector distribute in
some cases, making it hard to debug.

Signed-off-by: Stanley Winata <stanley.winata@amd.com>