tree 7789c2739d0ba2b030ccb617d06ad5d230567dee
parent aef6e1fc8fe85f4a57bc06b0272ada18975494fb
author Stanley Winata <68087699+raikonenfnu@users.noreply.github.com> 1729814198 -0700
committer GitHub <noreply@github.com> 1729814198 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJnGt62CRC1aQ7uu5UhlAAABsgQAA/A0PyDNoFmfii2diqqHZFe
 U0334DjkDBxwkaT+ipvUAEn/RntHbpTubtDfy6ur3qdojIV7l4D/m/S/FkpH8sAS
 4FEcU8bs4nV05efs8sq2j1x8Xsi69zaHRO/eHUmLs/W+qEoOiHUaoA7picV6OLLm
 2s4UN5Sp/emKK0n2MrM/l4uvKbhktJi2Z34LjLQNIXb4DBUT4MRclwQlAXfjTJvd
 XctuvR0Qsh9RDTfx6gy765rNufhwQPvqeXXQ/XuzUuRXoQT2Z+SvOhSIasNMaLKn
 wR6sNmMHvXttZ4gzHppgNt755Sx5bMaWonn3UWIBBnkb7KwqXHc/t5LaNZn24yDy
 CvOs6q5R4GGMFXl6lMOQgmD3sIOZ7U7oM2PMCn0q92BOTgkR/OV1A4hY+cHehUtk
 kbAZBw2dxwE4rMyBgDBRRkEf8zoOmgdWathkeRn2dxD2k5ZOlCwfh0YfTyTmD/vF
 4odQBwvDVTL4rhY3H+qXEgCTydHZ2lHXOK1jbrmFjK6Ce2/QfkKOw0O+TUq/yv1H
 J3WASLSl97euhqlBYPwbNs4922zm4Fzq53GqbGG27Qqas/lX9TrJl5NR0DWLamS3
 uCcMI4pBpkl4tmH3m8Pv25ic+GDf01XodZVbNlgYNDR2hMTvijGtYUj5sBVoOjPP
 PZmtHTYcYcENuEha3eTe
 =xMYU
 -----END PGP SIGNATURE-----
 

[VectorLayout] Fix insertion of new constOp for non dominate issue. (#18894)

Main motivation of this patch is to resolve issue where we have the same
constOp being used by multiple operations.

But with a twist where first time the constOp needs a layout is on a op
that topologically comes after other ops that use constOp. This will
generate a copy of constOp in the location right before the latter op,
which is problematic because this constOp will be used by other ops
before it.

Previously for the test added we get this error:
```
within split at contraction_layout.mlir:1 offset :24:10: note: see current operation: %9 = "arith.addf"(%8, %6) <{fastmath = #arith.fastmath<none>}> : (vector<96x64xf16>, vector<96x64xf16>) -> vector<96x64xf16>
within split at contraction_layout.mlir:1 offset :22:19: error: operand #1 does not dominate this use
    %scaled_rhs = arith.mulf %read_1, %cst_1 : vector<96x64xf16>
```

While minor, this is also problematic because this error seem to stopped
layout analysis (but not fatally) S.T it fails to vector distribute in
some cases, making it hard to debug.

Signed-off-by: Stanley Winata <stanley.winata@amd.com>