Rename 'external' to 'non_hermetic' in Keras BUILD files (#3642)
diff --git a/docs/developing_iree/e2e_benchmarking.md b/docs/developing_iree/e2e_benchmarking.md index ba4cb3f..6f27bc1 100644 --- a/docs/developing_iree/e2e_benchmarking.md +++ b/docs/developing_iree/e2e_benchmarking.md
@@ -98,7 +98,7 @@ wildcard expansion. They can be run by invoking the following test suite: ```shell -$ python3 ./scripts/get_e2e_artifacts.py --test_suites=vision_external_tests +$ python3 ./scripts/get_e2e_artifacts.py --test_suites=imagenet_non_hermetic_tests ``` The previous command compiles `MobileNet`, `MobileNetV2` and `ResNet50` to run
diff --git a/integrations/tensorflow/e2e/keras/BUILD b/integrations/tensorflow/e2e/keras/BUILD index 9875dde..945b56d 100644 --- a/integrations/tensorflow/e2e/keras/BUILD +++ b/integrations/tensorflow/e2e/keras/BUILD
@@ -164,7 +164,7 @@ ) iree_e2e_cartesian_product_test_suite( - name = "large_cifar10_internal_tests", + name = "large_cifar10_tests", size = "large", srcs = ["vision_model_test.py"], flags_to_values = { @@ -194,7 +194,7 @@ ) iree_e2e_cartesian_product_test_suite( - name = "enormous_cifar10_internal_tests", + name = "enormous_cifar10_tests", size = "enormous", srcs = ["vision_model_test.py"], failing_configurations = [ @@ -248,8 +248,9 @@ ], ) +# 'non_hermetic' tests use real model weights to test numerical correctness. iree_e2e_cartesian_product_test_suite( - name = "cifar10_external_tests", + name = "cifar10_non_hermetic_tests", size = "large", srcs = ["vision_model_test.py"], flags_to_values = { @@ -284,8 +285,9 @@ ], ) +# 'non_hermetic' tests use real model weights to test numerical correctness. iree_e2e_cartesian_product_test_suite( - name = "imagenet_external_tests", + name = "imagenet_non_hermetic_tests", size = "enormous", srcs = ["vision_model_test.py"], failing_configurations = [
diff --git a/scripts/get_e2e_artifacts.py b/scripts/get_e2e_artifacts.py index 7ed2691..9fb62ea 100755 --- a/scripts/get_e2e_artifacts.py +++ b/scripts/get_e2e_artifacts.py
@@ -43,8 +43,8 @@ '//integrations/tensorflow/e2e:mobile_bert_squad_tests', 'keras_tests': '//integrations/tensorflow/e2e/keras:keras_tests', - 'imagenet_external_tests': - '//integrations/tensorflow/e2e/keras:imagenet_external_tests', + 'imagenet_non_hermetic_tests': + '//integrations/tensorflow/e2e/keras:imagenet_non_hermetic_tests', 'slim_vision_tests': '//integrations/tensorflow/e2e/slim_vision_models:slim_vision_tests', }
diff --git a/scripts/update_e2e_coverage.py b/scripts/update_e2e_coverage.py index 11d8d52..ab91938 100755 --- a/scripts/update_e2e_coverage.py +++ b/scripts/update_e2e_coverage.py
@@ -52,7 +52,7 @@ f'End to end tests of {KWS_LINK} models', '//integrations/tensorflow/e2e/keras:keyword_spotting_internal_streaming_tests': f'End to end tests of {KWS_LINK} models in internal streaming mode', - '//integrations/tensorflow/e2e/keras:imagenet_external_tests': + '//integrations/tensorflow/e2e/keras:imagenet_non_hermetic_tests': 'End to end tests of tf.keras.applications vision models on Imagenet', '//integrations/tensorflow/e2e/slim_vision_models:slim_vision_tests': 'End to end tests of TensorFlow slim vision models', @@ -65,7 +65,7 @@ 'model', '//integrations/tensorflow/e2e/keras:keyword_spotting_internal_streaming_tests': 'model', - '//integrations/tensorflow/e2e/keras:imagenet_external_tests': + '//integrations/tensorflow/e2e/keras:imagenet_non_hermetic_tests': 'model', '//integrations/tensorflow/e2e/slim_vision_models:slim_vision_tests': 'model', @@ -78,7 +78,7 @@ 'keyword_spotting_streaming_test', '//integrations/tensorflow/e2e/keras:keyword_spotting_internal_streaming_tests': 'keyword_spotting_streaming_test', - '//integrations/tensorflow/e2e/keras:imagenet_external_tests': + '//integrations/tensorflow/e2e/keras:imagenet_non_hermetic_tests': 'vision_model_test', '//integrations/tensorflow/e2e/slim_vision_models:slim_vision_tests': 'slim_vision_model_test',