commit e278a60fd21d9d6df5a770051cf033b2ed87418f
author Timothy Chen <timothytim@google.com> Tue May 10 14:13:32 2022 -0700
committer tjaychen <timothytim@google.com> Thu May 12 07:48:09 2022 -0700
tree c20a6efdc6415f4c3bde1fc6ab307d65064e8127
parent a0972df982296783342a55f3f06654173813bad9

[dv/flash_ctrl] Update region address check

- the previous address range check was inclusive. Meaning
  if base is set to 0, and size set to 1, and access to
  access 1 would be "allowed". This is not the intended
  behavior.  If base is set to 0, and size is set to 1,
  only accesses to 0 should be allowed, 1 and above would
  be disallowed.

- the fix aligns the scoreboard / design behavior for the
  occassional flash_ctrl_mp failures.

Signed-off-by: Timothy Chen <timothytim@google.com>

hw/ip/flash_ctrl/dv/env/flash_ctrl_scoreboard.sv

diff --git a/hw/ip/flash_ctrl/dv/env/flash_ctrl_scoreboard.sv b/hw/ip/flash_ctrl/dv/env/flash_ctrl_scoreboard.sv
index 02e24e0..3a7360e 100644
--- a/hw/ip/flash_ctrl/dv/env/flash_ctrl_scoreboard.sv
+++ b/hw/ip/flash_ctrl/dv/env/flash_ctrl_scoreboard.sv
@@ -543,7 +543,7 @@
               base = get_field_val(ral.mp_region[i].base, data);
               size = get_field_val(ral.mp_region[i].size, data);
               if (in_erase_addr
-                  inside {[base*BytesPerPage:base*BytesPerPage+size*BytesPerPage]}) begin
+                  inside {[base*BytesPerPage:base*BytesPerPage+size*BytesPerPage-1]}) begin
                 if (en) begin
                   erase_access       = erase_en;
                   erase_access_found = 1'b1;