[spi_host, rtl] Clarify transitions for "bypassable" idle states

The SPI_HOST idle states `Idle` and `IdleCSBActive` are bypassable, meaning if
their exit condition is satisfied, the FSM can transition immediately from the
pre-idle to the next post-idle state. (See the SPI_HOST specification for more
details.)

This commit simply refactors the previous implementation for better clarity and
robustness.

Prior to this commit there was duplicated code in both the idle states,
as well as their preceding states.  This makes the code both harder to
follow and more bug-prone, as disparate edits can be made in either place.

This commit adds new signals: state_after_idle and state_after_idle_csb_active
to compute the next state when the exit condition for both states.
These signals are then explicitly examined in the pre-idle state to
perform the idle-bypass if appropriate.

A bypass can only occur if command_ready is asserted, the command_ready
signal is also asserted up to one clock cycle before entering an idle state
So the always_comb blocks that compute state_after_idle_csb_active therefore
also perform the neccesary computation for the command_ready signal.  Which is
somewhat complex because of the possibility of an aborted CSAAT segment.
(command_ready is always high in the idle state or one cycle before the
idle state)

----

In addition this commit changes how configuration changes are identified.
Previously a configuration change was assumed to happen only when CSID changed
between two command segments.  The FSM now also checks for any changes in the
configopts structure passed in with the command segment.

Signed-off-by: Martin Lueker-Boden <martin.lueker-boden@wdc.com>
1 file changed
tree: d2947e97b5fdeb59aafa0f6f13fc7a1f886c90c8
  1. .github/
  2. ci/
  3. doc/
  4. hw/
  5. rules/
  6. site/
  7. sw/
  8. test/
  9. util/
  10. .bazelignore
  11. .bazelrc
  12. .bazelversion
  13. .clang-format
  14. .dockerignore
  15. .flake8
  16. .gitignore
  17. .style.yapf
  18. .svlint.toml
  19. .svls.toml
  20. _index.md
  21. apt-requirements.txt
  22. azure-pipelines.yml
  23. BUILD
  24. check_tool_requirements.core
  25. CLA
  26. COMMITTERS
  27. CONTRIBUTING.md
  28. LICENSE
  29. meson.build
  30. meson_init.sh
  31. meson_options.txt
  32. python-requirements.txt
  33. README.md
  34. tool_requirements.py
  35. toolchain.txt
  36. topgen-reg-only.core
  37. topgen.core
  38. WORKSPACE
  39. yum-requirements.txt
README.md

OpenTitan

OpenTitan logo

About the project

OpenTitan is an open source silicon Root of Trust (RoT) project. OpenTitan will make the silicon RoT design and implementation more transparent, trustworthy, and secure for enterprises, platform providers, and chip manufacturers. OpenTitan is administered by lowRISC CIC as a collaborative project to produce high quality, open IP for instantiation as a full-featured product. See the OpenTitan site and OpenTitan docs for more information about the project.

About this repository

This repository contains hardware, software and utilities written as part of the OpenTitan project. It is structured as monolithic repository, or “monorepo”, where all components live in one repository. It exists to enable collaboration across partners participating in the OpenTitan project.

Documentation

The project contains comprehensive documentation of all IPs and tools. You can access it online at docs.opentitan.org.

How to contribute

Have a look at CONTRIBUTING and our documentation on project organization and processes for guidelines on how to contribute code to this repository.

Licensing

Unless otherwise noted, everything in this repository is covered by the Apache License, Version 2.0 (see LICENSE for full text).