commit c405edc5427462d1effd9aa82bb5c625c98fec7a
author Timothy Trippel <ttrippel@google.com> Tue Nov 29 14:00:34 2022 -0800
committer Timothy Trippel <5633066+timothytrippel@users.noreply.github.com> Wed Nov 30 13:38:50 2022 -0800
tree 1e1435108daff1d78c30e5e0dc0d2d6b3926bab3
parent 8821e9eac471d3a001eae207e70175232f1e8ee6

[rom_e2e,dv] apply reset after boot fault in vseq

When a ROM E2E test boot faults, an alert is generated. Ending a test
when an alert is fired triggers an assertion. This updates the ROM E2E
base sequence to apply a reset before ending the test to enable better
test portability in the future. Additionally this addresses review
feedback in #16335.

Signed-off-by: Timothy Trippel <ttrippel@google.com>

hw/top_earlgrey/dv/chip_rom_tests.hjson

diff --git a/hw/top_earlgrey/dv/chip_rom_tests.hjson b/hw/top_earlgrey/dv/chip_rom_tests.hjson
index aecc817..5597d2b 100644
--- a/hw/top_earlgrey/dv/chip_rom_tests.hjson
+++ b/hw/top_earlgrey/dv/chip_rom_tests.hjson
@@ -20,10 +20,7 @@
       uvm_test_seq: chip_sw_rom_e2e_shutdown_exception_c_vseq
       sw_images: ["//sw/device/silicon_creator/rom/e2e:rom_e2e_shutdown_exception_c:1:signed"]
       en_run_modes: ["sw_test_mode_rom"]
-      run_opts: [
-        "+sw_test_timeout_ns=20000000",
-        "+bypass_alert_ready_to_end_check=1",
-      ]
+      run_opts: ["+sw_test_timeout_ns=20000000"]
       run_timeout_mins: 120
     }
     {
@@ -38,7 +35,6 @@
       run_opts: [
         "+sw_test_timeout_ns=20000000",
         "+use_otp_image=OtpTypeCustom",
-        "+bypass_alert_ready_to_end_check=1",
       ]
     }
     {
@@ -293,7 +289,6 @@
       run_opts: [
         "+sw_test_timeout_ns=410_000_000",
         "+use_otp_image=OtpTypeCustom",
-        "+bypass_alert_ready_to_end_check=1",
       ]
       reseed: 1
       run_timeout_mins: 480
@@ -310,7 +305,6 @@
       run_opts: [
         "+sw_test_timeout_ns=50_000_000",
         "+use_otp_image=OtpTypeCustom",
-        "+bypass_alert_ready_to_end_check=1",
       ]
       reseed: 1
       run_timeout_mins: 120
@@ -327,7 +321,6 @@
       run_opts: [
         "+sw_test_timeout_ns=50_000_000",
         "+use_otp_image=OtpTypeCustom",
-        "+bypass_alert_ready_to_end_check=1",
       ]
       reseed: 1
       run_timeout_mins: 120
@@ -344,7 +337,6 @@
       run_opts: [
         "+sw_test_timeout_ns=50_000_000",
         "+use_otp_image=OtpTypeCustom",
-        "+bypass_alert_ready_to_end_check=1",
       ]
       reseed: 1
       run_timeout_mins: 120
@@ -361,7 +353,6 @@
       run_opts: [
         "+sw_test_timeout_ns=50_000_000",
         "+use_otp_image=OtpTypeCustom",
-        "+bypass_alert_ready_to_end_check=1",
       ]
       reseed: 1
       run_timeout_mins: 120
@@ -378,7 +369,6 @@
       run_opts: [
         "+sw_test_timeout_ns=410_000_000",
         "+use_otp_image=OtpTypeCustom",
-        "+bypass_alert_ready_to_end_check=1",
       ]
       reseed: 1
       run_timeout_mins: 480
@@ -395,7 +385,6 @@
       run_opts: [
         "+sw_test_timeout_ns=50_000_000",
         "+use_otp_image=OtpTypeCustom",
-        "+bypass_alert_ready_to_end_check=1",
       ]
       reseed: 1
       run_timeout_mins: 120
@@ -412,7 +401,6 @@
       run_opts: [
         "+sw_test_timeout_ns=50_000_000",
         "+use_otp_image=OtpTypeCustom",
-        "+bypass_alert_ready_to_end_check=1",
       ]
       reseed: 1
       run_timeout_mins: 120
@@ -429,7 +417,6 @@
       run_opts: [
         "+sw_test_timeout_ns=50_000_000",
         "+use_otp_image=OtpTypeCustom",
-        "+bypass_alert_ready_to_end_check=1",
       ]
       reseed: 1
       run_timeout_mins: 120
@@ -446,7 +433,6 @@
       run_opts: [
         "+sw_test_timeout_ns=50_000_000",
         "+use_otp_image=OtpTypeCustom",
-        "+bypass_alert_ready_to_end_check=1",
       ]
       reseed: 1
       run_timeout_mins: 120
@@ -463,7 +449,6 @@
       run_opts: [
         "+sw_test_timeout_ns=410_000_000",
         "+use_otp_image=OtpTypeCustom",
-        "+bypass_alert_ready_to_end_check=1",
       ]
       reseed: 1
       run_timeout_mins: 480
@@ -480,7 +465,6 @@
       run_opts: [
         "+sw_test_timeout_ns=50_000_000",
         "+use_otp_image=OtpTypeCustom",
-        "+bypass_alert_ready_to_end_check=1",
       ]
       reseed: 1
       run_timeout_mins: 120
@@ -497,7 +481,6 @@
       run_opts: [
         "+sw_test_timeout_ns=50_000_000",
         "+use_otp_image=OtpTypeCustom",
-        "+bypass_alert_ready_to_end_check=1",
       ]
       reseed: 1
       run_timeout_mins: 120
@@ -514,7 +497,6 @@
       run_opts: [
         "+sw_test_timeout_ns=50_000_000",
         "+use_otp_image=OtpTypeCustom",
-        "+bypass_alert_ready_to_end_check=1",
       ]
       reseed: 1
       run_timeout_mins: 120
@@ -531,7 +513,6 @@
       run_opts: [
         "+sw_test_timeout_ns=50_000_000",
         "+use_otp_image=OtpTypeCustom",
-        "+bypass_alert_ready_to_end_check=1",
       ]
       reseed: 1
       run_timeout_mins: 120