commit bb1aab7c403d8e36d29d9f978b9bda6cb51202db
author Cindy Chen <chencindy@google.com> Fri Jan 31 11:14:31 2020 -0800
committer cindychip <cindy.chen0316@gmail.com> Fri Jan 31 13:31:34 2020 -0800
tree 7fbbeb44f7dbd0b5cd1507c92bb9b82a17ee8d25
parent a821bbc1d0a3479a4852090b52e5e957c6f7ca09

[dv/common] pre_abort deadloop

Fix pre_abort deadloop

Signed-off-by: Cindy Chen <chencindy@google.com>

hw/dv/sv/dv_lib/dv_base_scoreboard.sv

diff --git a/hw/dv/sv/dv_lib/dv_base_scoreboard.sv b/hw/dv/sv/dv_lib/dv_base_scoreboard.sv
index ab7835e..c31bf53 100644
--- a/hw/dv/sv/dv_lib/dv_base_scoreboard.sv
+++ b/hw/dv/sv/dv_lib/dv_base_scoreboard.sv
@@ -11,7 +11,8 @@
   RAL_T    ral;
   COV_T    cov;
 
-  bit obj_raised = 1'b0;
+  bit obj_raised      = 1'b0;
+  bit under_pre_abort = 1'b0;
 
   `uvm_component_new
 
@@ -65,7 +66,16 @@
 
   virtual function void pre_abort();
     super.pre_abort();
-    if (has_uvm_fatal_occurred()) check_phase(m_current_phase);
+    // use under_pre_abort flag to prevent deadloop described below:
+    // when fatal_err occurred, it will skip check_phase. We add the additional check_phase call
+    // here to help debugging. But if inside the check_phase there are UVM_ERRORs, and the err cnt
+    // is larger than max_err_cnt, then check_phase will call pre_abort again. This will end up
+    // creating a deadloop.
+    if (has_uvm_fatal_occurred() && !under_pre_abort) begin
+      under_pre_abort = 1;
+      check_phase(m_current_phase);
+      under_pre_abort = 0;
+    end
   endfunction : pre_abort
 
 endclass