[dv] Add macro DV_LC_TX_DIST and update get_rand_lc_tx_val
lc_tx_pkg::On/Off is different than Mubi4True/False
Add a macro so that users can use `DV_LC_TX_DIST` in constraint
And update `get_rand_lc_tx_val` to use this constraint macro
Signed-off-by: Weicai Yang <weicai@google.com>
diff --git a/hw/dv/sv/cip_lib/cip_base_pkg.sv b/hw/dv/sv/cip_lib/cip_base_pkg.sv
index f5378a6..91a0f35 100644
--- a/hw/dv/sv/cip_lib/cip_base_pkg.sv
+++ b/hw/dv/sv/cip_lib/cip_base_pkg.sv
@@ -108,26 +108,11 @@
function automatic lc_ctrl_pkg::lc_tx_t get_rand_lc_tx_val(int t_weight = 2,
int f_weight = 2,
int other_weight = 1);
- // The lc_tx_t encoding is (intentionally) different from the mubi4_t encoding, but they do
- // roughly the same thing. To pick a random value, we pick a mubi4_t first and then apply a
- // bijection to map it to an lc_tx_t so that the special "true" and "false" values get mapped
- // appropriately.
- logic [3:0] as_mubi, as_lc;
- as_mubi = get_rand_mubi4_val(t_weight, f_weight, other_weight);
+ bit[3:0] val;
+ `DV_CHECK_STD_RANDOMIZE_WITH_FATAL(val,
+ `DV_LC_TX_DIST(val, t_weight, f_weight, other_weight), , msg_id)
- // The mapping that we choose swaps MuBi4True <-> On and MuBi4False <-> Off and leaves all other
- // values fixed. Note that this is a bijection so long as MuBi4True != MuBi4False and On != Off.
- // We don't need to assume anything about the relation between the two types' encodings (if
- // there are any collisions, we're just permuting fewer special points).
- case (as_mubi)
- MuBi4True: as_lc = lc_ctrl_pkg::On;
- MuBi4False: as_lc = lc_ctrl_pkg::Off;
- lc_ctrl_pkg::On: as_lc = MuBi4True;
- lc_ctrl_pkg::Off: as_lc = MuBi4False;
- default: as_lc = as_mubi;
- endcase
-
- return lc_ctrl_pkg::lc_tx_t'(as_lc);
+ return lc_ctrl_pkg::lc_tx_t'(val);
endfunction
// package sources
diff --git a/hw/dv/sv/cip_lib/cip_macros.svh b/hw/dv/sv/cip_lib/cip_macros.svh
index e968be9..ce28fb5 100644
--- a/hw/dv/sv/cip_lib/cip_macros.svh
+++ b/hw/dv/sv/cip_lib/cip_macros.svh
@@ -76,6 +76,12 @@
// T_WEIGHT_: randomization weight of the value True
// F_WEIGHT_: randomization weight of the value False
// OTHER_WEIGHT_: randomization weight of values other than True or False
+`ifndef DV_LC_TX_DIST
+`define DV_LC_TX_DIST(VAR_, T_WEIGHT_ = 2, F_WEIGHT_ = 2, OTHER_WEIGHT_ = 1) \
+ `_DV_MUBI_DIST(VAR_, lc_ctrl_pkg::On, lc_ctrl_pkg::Off, (1 << 4) - 1, T_WEIGHT_, F_WEIGHT_, \
+ OTHER_WEIGHT_)
+`endif
+
`ifndef DV_MUBI4_DIST
`define DV_MUBI4_DIST(VAR_, T_WEIGHT_ = 2, F_WEIGHT_ = 2, OTHER_WEIGHT_ = 1) \
`_DV_MUBI_DIST(VAR_, MuBi4True, MuBi4False, (1 << 4) - 1, T_WEIGHT_, F_WEIGHT_, OTHER_WEIGHT_)
