[ci] Add checks for empty test_suites (and more!)

This commit adds scripts that check for empty test_suite targets and
targets that contain "banned" characters. It also re-homes the check for
test_suite targets that are not tagged "manual".

I'm adding these scripts after making a few mistakes while cleaning up a
BUILD file in PR #16401.

My first mistake was forgetting to unpack a tuple. I wound up inserting
the tuple's string representation, rather than one of the tuple's
elements, into a target name via `string.format()`. Surprisingly, this
is not an analysis-time failure! Bazel has no problem inserting
parentheses and commas into the target name.

If weird characters are in a target name, for some definition of
"weird", it was probably an accident. The new script returns an error
when it finds targets with weird characters.

The second mistake I made was defining a test_suite with a non-empty
`tests` parameter, where none of the labels actually existed. The result
is a test_suite that appears non-empty, but actually contains zero
tests.

I believe an empty test_suite indicates an error. The new script returns
an error if it finds any test_suite targets that contain zero tests.

Signed-off-by: Dan McArdle <dmcardle@google.com>
7 files changed
tree: ae993683ff9864458165abf92dbaaf92215c63c3
  1. .github/
  2. ci/
  3. doc/
  4. hw/
  5. quality/
  6. release/
  7. rules/
  8. site/
  9. sw/
  10. third_party/
  11. util/
  12. .bazelignore
  13. .bazelrc
  14. .bazelversion
  15. .clang-format
  16. .dockerignore
  17. .flake8
  18. .gitattributes
  19. .gitignore
  20. .style.yapf
  21. .svlint.toml
  22. .svls.toml
  23. _index.md
  24. apt-requirements.txt
  25. azure-pipelines.yml
  26. bazelisk.sh
  27. BUILD.bazel
  28. check_tool_requirements.core
  29. CLA
  30. COMMITTERS
  31. CONTRIBUTING.md
  32. LICENSE
  33. mypy.ini
  34. python-requirements.txt
  35. README.md
  36. tool_requirements.py
  37. topgen-reg-only.core
  38. topgen.core
  39. WORKSPACE
  40. yum-requirements.txt
README.md

OpenTitan

OpenTitan logo

About the project

OpenTitan is an open source silicon Root of Trust (RoT) project. OpenTitan will make the silicon RoT design and implementation more transparent, trustworthy, and secure for enterprises, platform providers, and chip manufacturers. OpenTitan is administered by lowRISC CIC as a collaborative project to produce high quality, open IP for instantiation as a full-featured product. See the OpenTitan site and OpenTitan docs for more information about the project.

About this repository

This repository contains hardware, software and utilities written as part of the OpenTitan project. It is structured as monolithic repository, or “monorepo”, where all components live in one repository. It exists to enable collaboration across partners participating in the OpenTitan project.

Documentation

The project contains comprehensive documentation of all IPs and tools. You can access it online at docs.opentitan.org.

How to contribute

Have a look at CONTRIBUTING and our documentation on project organization and processes for guidelines on how to contribute code to this repository.

Licensing

Unless otherwise noted, everything in this repository is covered by the Apache License, Version 2.0 (see LICENSE for full text).