commit | 465f8939c4fae38dff384cb0d0a032508862b593 | [log] [tgz] |
---|---|---|
author | Dan McArdle <dmcardle@google.com> | Thu Nov 17 14:15:59 2022 -0500 |
committer | Drew Macrae <drewmacrae@gmail.com> | Tue Nov 29 15:56:52 2022 -0500 |
tree | ae993683ff9864458165abf92dbaaf92215c63c3 | |
parent | 7a661ea0f33401005128a5e2cd6564826047268e [diff] |
[ci] Add checks for empty test_suites (and more!) This commit adds scripts that check for empty test_suite targets and targets that contain "banned" characters. It also re-homes the check for test_suite targets that are not tagged "manual". I'm adding these scripts after making a few mistakes while cleaning up a BUILD file in PR #16401. My first mistake was forgetting to unpack a tuple. I wound up inserting the tuple's string representation, rather than one of the tuple's elements, into a target name via `string.format()`. Surprisingly, this is not an analysis-time failure! Bazel has no problem inserting parentheses and commas into the target name. If weird characters are in a target name, for some definition of "weird", it was probably an accident. The new script returns an error when it finds targets with weird characters. The second mistake I made was defining a test_suite with a non-empty `tests` parameter, where none of the labels actually existed. The result is a test_suite that appears non-empty, but actually contains zero tests. I believe an empty test_suite indicates an error. The new script returns an error if it finds any test_suite targets that contain zero tests. Signed-off-by: Dan McArdle <dmcardle@google.com>
OpenTitan is an open source silicon Root of Trust (RoT) project. OpenTitan will make the silicon RoT design and implementation more transparent, trustworthy, and secure for enterprises, platform providers, and chip manufacturers. OpenTitan is administered by lowRISC CIC as a collaborative project to produce high quality, open IP for instantiation as a full-featured product. See the OpenTitan site and OpenTitan docs for more information about the project.
This repository contains hardware, software and utilities written as part of the OpenTitan project. It is structured as monolithic repository, or “monorepo”, where all components live in one repository. It exists to enable collaboration across partners participating in the OpenTitan project.
The project contains comprehensive documentation of all IPs and tools. You can access it online at docs.opentitan.org.
Have a look at CONTRIBUTING and our documentation on project organization and processes for guidelines on how to contribute code to this repository.
Unless otherwise noted, everything in this repository is covered by the Apache License, Version 2.0 (see LICENSE for full text).