Google Git
Sign in
opensecura / 3p / lowrisc / opentitan / a9aec87b1fdd7426082e032b47e5e6760aa3de8f
commita9aec87b1fdd7426082e032b47e5e6760aa3de8f[log] [tgz]
authorMartin Lueker-Boden <martin.lueker-boden@wdc.com>Tue Nov 23 17:35:22 2021 -0800
committerMartin Lueker-Boden <47870387+martin-lueker@users.noreply.github.com>Wed Nov 24 13:59:27 2021 -0800
tree2b88a8b2d427c615b8f70c6010a14daf406c780b
parent6c83a36a39b09fd7cc87110cee0dd71c84b88f1e [diff]
[ spi_host, rtl ] Properly handle back-to-back segments

Issue #9285 uncovers a bug whereby back-to-back segments are not being properly handled in the rtl.

The issue is that when processing back to back segments, the FSM needs to carefully choose which copy
of the segment parameters to look at.  For anything initializing states for the following segment the
FSM needs to look at the new incoming segment parameters.  For finalizing processing of the previous segment
(e.g., flushing data out of the shift register) the FSM needs to look at the previous parameters.

This commit manages this subtlety.

Fixes #9285 (with patch to test bench in @rasmus-madsen's offline TB, see issue for patch)

Signed-off-by: Martin Lueker-Boden <martin.lueker-boden@wdc.com>
1 file changed
tree: 2b88a8b2d427c615b8f70c6010a14daf406c780b
  1. .github/
  2. ci/
  3. doc/
  4. hw/
  5. rules/
  6. site/
  7. sw/
  8. test/
  9. util/
  10. .bazelignore
  11. .bazelrc
  12. .bazelversion
  13. .clang-format
  14. .dockerignore
  15. .flake8
  16. .gitignore
  17. .style.yapf
  18. .svlint.toml
  19. .svls.toml
  20. _index.md
  21. apt-requirements.txt
  22. azure-pipelines.yml
  23. BUILD
  24. check_tool_requirements.core
  25. CLA
  26. COMMITTERS
  27. CONTRIBUTING.md
  28. LICENSE
  29. meson.build
  30. meson_init.sh
  31. meson_options.txt
  32. python-requirements.txt
  33. README.md
  34. tool_requirements.py
  35. toolchain.txt
  36. topgen-reg-only.core
  37. topgen.core
  38. WORKSPACE
  39. yum-requirements.txt
README.md

OpenTitan

OpenTitan logo

About the project

OpenTitan is an open source silicon Root of Trust (RoT) project. OpenTitan will make the silicon RoT design and implementation more transparent, trustworthy, and secure for enterprises, platform providers, and chip manufacturers. OpenTitan is administered by lowRISC CIC as a collaborative project to produce high quality, open IP for instantiation as a full-featured product. See the OpenTitan site and OpenTitan docs for more information about the project.

About this repository

This repository contains hardware, software and utilities written as part of the OpenTitan project. It is structured as monolithic repository, or “monorepo”, where all components live in one repository. It exists to enable collaboration across partners participating in the OpenTitan project.

Documentation

The project contains comprehensive documentation of all IPs and tools. You can access it online at docs.opentitan.org.

How to contribute

Have a look at CONTRIBUTING and our documentation on project organization and processes for guidelines on how to contribute code to this repository.

Licensing

Unless otherwise noted, everything in this repository is covered by the Apache License, Version 2.0 (see LICENSE for full text).