commit | a25377dd68a8d428fcb7457c38503bbff3f794b3 | [log] [tgz] |
---|---|---|
author | Pirmin Vogel <vogelpi@lowrisc.org> | Tue Feb 18 11:24:43 2020 +0100 |
committer | Philipp Wagner <mail@philipp-wagner.com> | Fri Feb 21 18:35:56 2020 +0000 |
tree | e023ee30a63f99bbabb52d64f4e10fbc3aef9efb | |
parent | 01ecafe18c79e269542b7d19cfd74c91a358da14 [diff] |
[aes/rtl] Fix controller behavior when stalling the cipher core This commit corrects two issues in the behavior of the main controller when the stalling the cipher core (because the DATA_OUT registers cannot yet be overwritten). 1) The controller must not overwrite the DATA_OUT registers and not proceed to the next state until the DATA_OUT registers have been read by software. Without this commit, the controller keeps the cipher core stalled (and waiting forever) but still proceeds. 2) The stall bit in the STATUS register must only be asserted if the cipher core has valid output and is indeed being stalled. Without this commit, the stall bit is asserted also when the cipher core is still busy and does not yet have valid output. This resolves lowRISC/OpenTitan#1560 reported by @labbott. Signed-off-by: Pirmin Vogel <vogelpi@lowrisc.org>
OpenTitan is an open source silicon Root of Trust (RoT) project. OpenTitan will make the silicon RoT design and implementation more transparent, trustworthy, and secure for enterprises, platform providers, and chip manufacturers. OpenTitan is administered by lowRISC CIC as a collaborative project to produce high quality, open IP for instantiation as a full-featured product. See the OpenTitan site and OpenTitan docs for more information about the project.
This repository contains hardware, software and utilities written as part of the OpenTitan project. It is structured as monolithic repository, or “monorepo”, where all components live in one repository. It exists to enable collaboration across partners participating in the OpenTitan project.
The project contains comprehensive documentation of all IPs and tools. You can either access it online or build it locally by following the steps below.
$ sudo apt install curl python3 python3-pip $ pip3 install --user -r python-requirements.txt
$ ./util/build_docs.py --preview
This compiles the documentation into ./build/docs
and starts a local server, which allows you to access the documentation at http://127.0.0.1:1313.
Have a look at CONTRIBUTING for guidelines on how to contribute code to this repository.
Unless otherwise noted, everything in this repository is covered by the Apache License, Version 2.0 (see LICENSE for full text).