commit 990172236cde9a9b145aa450b35c7efe305610eb
author Philipp Wagner <phw@lowrisc.org> Wed Jul 14 11:17:29 2021 +0100
committer Philipp Wagner <mail@philipp-wagner.com> Wed Jul 14 13:38:07 2021 +0100
tree a0e5f1f1f2472457cf71d2ce70fa7ba0216ea777
parent 02e982f3b357340ab49e2d8c2580c77253480b65

[dv] Small optimization in memutil

GCC11 suggests using a reference, so let's do that!

```
../src/lowrisc_dv_verilator_memutil_dpi_0/cpp/dpi_memutil.cc:434:21: warning: loop variable ‘seg_pr’ creates a copy from type ‘const std::pair<const AddrRange<unsigned int>, std::vector<unsigned char> >’ [-Wrange-loop-construct]
  434 |     for (const auto seg_pr : staged_mem.GetSegs()) {
      |                     ^~~~~~
../src/lowrisc_dv_verilator_memutil_dpi_0/cpp/dpi_memutil.cc:434:21: note: use reference type to prevent copying
  434 |     for (const auto seg_pr : staged_mem.GetSegs()) {
      |                     ^~~~~~
      |                     &
```

Signed-off-by: Philipp Wagner <phw@lowrisc.org>

hw/dv/verilator/cpp/dpi_memutil.cc

diff --git a/hw/dv/verilator/cpp/dpi_memutil.cc b/hw/dv/verilator/cpp/dpi_memutil.cc
index 458b53f..c57a3ee 100644
--- a/hw/dv/verilator/cpp/dpi_memutil.cc
+++ b/hw/dv/verilator/cpp/dpi_memutil.cc
@@ -431,7 +431,7 @@
 
     const MemArea &mem_area = *mem_areas_[mem_area_it->second];
 
-    for (const auto seg_pr : staged_mem.GetSegs()) {
+    for (const auto &seg_pr : staged_mem.GetSegs()) {
       const AddrRange<uint32_t> &seg_rng = seg_pr.first;
       const std::vector<uint8_t> &seg_data = seg_pr.second;