| commit | 96a9fa18d73b542cf96d5d64916ae4c233d99624 | [log] [tgz] |
|---|---|---|
| author | Philipp Wagner <phw@lowrisc.org> | Wed Aug 11 09:42:57 2021 +0100 |
| committer | Philipp Wagner <mail@philipp-wagner.com> | Wed Aug 11 12:59:46 2021 +0100 |
| tree | 8e481561bd031e65ed764aedb3ed2531cc424330 | |
| parent | 92ec83e923e570167989d496e3fa9ae5762c83b1 [diff] |
[prim_lfsr] Do not shadow |state| variable
A variable called `state` is used inside a function (with function
scope), and also in the module with module scope. This makes the
variable in the function shadow the one in the module. Verilator reports
this as lint warning. Since we build the OTBN smoke test in a way that
fails on warnings, we get a failing CI run for the OTBN smoke test.
This commit renames the variable inside the function to avoid the
shadowing.
```
%Warning-VARHIDDEN: ../src/lowrisc_prim_lfsr_0.1/rtl/prim_lfsr.sv:420:80: Declaration of signal hides declaration in upper scope: 'state'
420 | logic[LfsrDw-1:0] state);
| ^~~~~
../src/lowrisc_prim_lfsr_0.1/rtl/prim_lfsr.sv:377:26: ... Location of original declaration
377 | logic [StateOutDw-1:0] state;
| ^~~~~
... Use "/* verilator lint_off VARHIDDEN */" and lint_on around source to disable this message.
```
Signed-off-by: Philipp Wagner <phw@lowrisc.org>
OpenTitan is an open source silicon Root of Trust (RoT) project. OpenTitan will make the silicon RoT design and implementation more transparent, trustworthy, and secure for enterprises, platform providers, and chip manufacturers. OpenTitan is administered by lowRISC CIC as a collaborative project to produce high quality, open IP for instantiation as a full-featured product. See the OpenTitan site and OpenTitan docs for more information about the project.
This repository contains hardware, software and utilities written as part of the OpenTitan project. It is structured as monolithic repository, or “monorepo”, where all components live in one repository. It exists to enable collaboration across partners participating in the OpenTitan project.
The project contains comprehensive documentation of all IPs and tools. You can access it online at docs.opentitan.org.
Have a look at CONTRIBUTING and our documentation on project organization and processes for guidelines on how to contribute code to this repository.
Unless otherwise noted, everything in this repository is covered by the Apache License, Version 2.0 (see LICENSE for full text).