[otbn,dv] Fix segfault when otbn_top_sim exited with failure

The verilator_top.reset() line was only being run when we exited
successfully. If not, we ended up destructing the std::unique_ptr and
thus its contents somewhere inside the CRT's run_exit_handlers.

It turns out that there's a race where a singleton in the Verilator
library *must* exist when you run the constructor or destructor and
you get a segfault if verilator_top happens to have a longer lifetime
than the singleton.

Fix things by being stupider: use a raw pointer to pass the object to
OtbnTopApplyLoopWarp (the DPI function that needs it). This will be
dangling after we exit main() and have destroyed the object, but we
don't really care.

Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
1 file changed
tree: 829f3cc975ef99c87a1e12c6cbcc7bee801bc7c5
  1. .github/
  2. ci/
  3. doc/
  4. hw/
  5. rules/
  6. site/
  7. sw/
  8. test/
  9. util/
  10. .bazelversion
  11. .clang-format
  12. .dockerignore
  13. .flake8
  14. .gitignore
  15. .style.yapf
  16. .svlint.toml
  17. .svls.toml
  18. _index.md
  19. apt-requirements.txt
  20. azure-pipelines.yml
  21. BUILD
  22. check_tool_requirements.core
  23. CLA
  24. COMMITTERS
  25. CONTRIBUTING.md
  26. LICENSE
  27. meson.build
  28. meson_init.sh
  29. meson_options.txt
  30. python-requirements.txt
  31. README.md
  32. tool_requirements.py
  33. toolchain.txt
  34. topgen-generator.core
  35. topgen-reg-only.core
  36. topgen.core
  37. WORKSPACE
  38. yum-requirements.txt
README.md

OpenTitan

OpenTitan logo

About the project

OpenTitan is an open source silicon Root of Trust (RoT) project. OpenTitan will make the silicon RoT design and implementation more transparent, trustworthy, and secure for enterprises, platform providers, and chip manufacturers. OpenTitan is administered by lowRISC CIC as a collaborative project to produce high quality, open IP for instantiation as a full-featured product. See the OpenTitan site and OpenTitan docs for more information about the project.

About this repository

This repository contains hardware, software and utilities written as part of the OpenTitan project. It is structured as monolithic repository, or “monorepo”, where all components live in one repository. It exists to enable collaboration across partners participating in the OpenTitan project.

Documentation

The project contains comprehensive documentation of all IPs and tools. You can access it online at docs.opentitan.org.

How to contribute

Have a look at CONTRIBUTING and our documentation on project organization and processes for guidelines on how to contribute code to this repository.

Licensing

Unless otherwise noted, everything in this repository is covered by the Apache License, Version 2.0 (see LICENSE for full text).