commit 7f4b87c7bb35bf7b338d1ae547d319ac43cbe0ef
author Philipp Wagner <phw@lowrisc.org> Tue Sep 08 11:34:03 2020 +0100
committer Sam Elliott <sam@lenary.co.uk> Fri Sep 11 16:08:32 2020 +0100
tree c6d0bfe22a95f39d0933a580b4e931aaa6a728c3
parent 9afc6d246792e5c4a168a3a0ec510390de5128e4

[OTBN/DIF] Use a non-zero error code in mock tests

Previously, only an error code with value 0 was available for testing,
now we also have a non-zero error code available. Use a non-zero error
code to also catch cases where zero is the default (uninitialized)
value.

Signed-off-by: Philipp Wagner <phw@lowrisc.org>

sw/device/tests/dif/dif_otbn_unittest.cc

diff --git a/sw/device/tests/dif/dif_otbn_unittest.cc b/sw/device/tests/dif/dif_otbn_unittest.cc
index b738a8c..74518fd 100644
--- a/sw/device/tests/dif/dif_otbn_unittest.cc
+++ b/sw/device/tests/dif/dif_otbn_unittest.cc
@@ -332,19 +332,19 @@
   result = dif_otbn_get_err_code(&dif_otbn_, nullptr);
   EXPECT_EQ(result, kDifOtbnBadArg);
 
-  err_code = kDifOtbnErrCodeNoError;
+  err_code = kDifOtbnErrCodeBadDataAddr;
   result = dif_otbn_get_err_code(nullptr, &err_code);
   EXPECT_EQ(result, kDifOtbnBadArg);
-  EXPECT_EQ(err_code, kDifOtbnErrCodeNoError);
+  EXPECT_EQ(err_code, kDifOtbnErrCodeBadDataAddr);
 }
 
 TEST_F(GetErrCodeTest, Success) {
-  EXPECT_READ32(OTBN_ERR_CODE_REG_OFFSET, kDifOtbnErrCodeNoError);
+  EXPECT_READ32(OTBN_ERR_CODE_REG_OFFSET, kDifOtbnErrCodeBadDataAddr);
 
   dif_otbn_err_code_t err_code;
   dif_otbn_result_t result = dif_otbn_get_err_code(&dif_otbn_, &err_code);
   EXPECT_EQ(result, kDifOtbnOk);
-  EXPECT_EQ(err_code, kDifOtbnErrCodeNoError);
+  EXPECT_EQ(err_code, kDifOtbnErrCodeBadDataAddr);
 }
 
 TEST_F(GetErrCodeTest, HardwareReturnsUnknownErrorCode) {
@@ -352,12 +352,12 @@
   // error code.
   EXPECT_READ32(OTBN_ERR_CODE_REG_OFFSET, 1234);
 
-  dif_otbn_err_code_t err_code = kDifOtbnErrCodeNoError;
+  dif_otbn_err_code_t err_code = kDifOtbnErrCodeBadDataAddr;
   dif_otbn_result_t result = dif_otbn_get_err_code(&dif_otbn_, &err_code);
   EXPECT_EQ(result, kDifOtbnUnexpectedData);
 
   // Should stay unchanged.
-  EXPECT_EQ(err_code, kDifOtbnErrCodeNoError);
+  EXPECT_EQ(err_code, kDifOtbnErrCodeBadDataAddr);
 }
 
 class ImemWriteTest : public OtbnTest {};