commit 7e07af14385773cdeb0031b7150d23497bb18c00
author Miles Dai <milesdai@google.com> Thu Jul 07 16:27:33 2022 -0400
committer Alphan Ulusoy <alphan@google.com> Mon Aug 15 22:17:02 2022 -0400
tree 4b96341c9087123c7f558f84d5d51ca84577b691
parent 762b9ae2d286ad9d5783d43526bf4174d6af68fb

[lint] Fix shellcheck errors in bazelisk.sh and rules/

Signed-off-by: Miles Dai <milesdai@google.com>

bazelisk.sh

diff --git a/bazelisk.sh b/bazelisk.sh
index bf5a162..3233e86 100755
--- a/bazelisk.sh
+++ b/bazelisk.sh
@@ -31,20 +31,23 @@
 )
 
 function os_arch() {
-    local arch="$(uname -m -o)"
+    local arch
+    arch="$(uname -m -o)"
     echo "${architectures[$arch]:-${arch}}"
 }
 
 function check_hash() {
-    local file="$1"
-    local target="$(os_arch)"
-    local value="$(sha256sum "${file}" | cut -f1 -d' ')"
+    local file target value
+    file="$1"
+    target="$(os_arch)"
+    value="$(sha256sum "${file}" | cut -f1 -d' ')"
     local expect="${hashes[$target]}"
-    return $(test "$value" == "$expect")
+    test "$value" == "$expect"
 }
 
 function prepare() {
-    local target="$(os_arch)"
+    local target
+    target="$(os_arch)"
     local bindir="${REPO_TOP}/${BINDIR}"
     local file="${bindir}/bazelisk"
     local url="https://github.com/bazelbuild/bazelisk/releases/download/${release}/bazelisk-${target}"