| commit | 49e9d452deab7118a6a34bae3ef892d391a1cccd | [log] [tgz] |
|---|---|---|
| author | Rupert Swarbrick <rswarbrick@lowrisc.org> | Tue Jul 27 14:44:18 2021 +0100 |
| committer | Rupert Swarbrick <rswarbrick@gmail.com> | Thu Jul 29 11:35:36 2021 +0100 |
| tree | 4bcfe6677a26c6c9d8fb7a897c28b63390759edb | |
| parent | 10cfc6878845e6defa2148c787c93f1d92ef8b6c [diff] |
[otbn] Simplify loop end calculation logic The previous code separated out two cases depending on whether IMEM was small or large compared to the 12-bit bodysize from the ISA. Even with a large IMEM width, we still have the possibility of an overflow in the addition (because the loop instruction might be at the top of the address space). The existing code was correct, but I think both branches of the "if" block did the same thing in the "big IMEM" case: the unary OR in the first branch ends up operating on a single bit. Simplify things by getting rid of the "if" block and just using the first branch. Also, increment LoopEndAddrWidth by 1 so that the name is accurate and write a comment explaining why this is the right calculation. There's a small optimisation opportunity here: If we taught otbn_loop_controller about the size of IMEM as well as its width, we might have a maximum instruction address that's more than 2^14 smaller than 2^ImemAddrWidth. But that only matters if IMEM is large and isn't a power of 2 in size. At the moment, it's a small power of 2! Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
OpenTitan is an open source silicon Root of Trust (RoT) project. OpenTitan will make the silicon RoT design and implementation more transparent, trustworthy, and secure for enterprises, platform providers, and chip manufacturers. OpenTitan is administered by lowRISC CIC as a collaborative project to produce high quality, open IP for instantiation as a full-featured product. See the OpenTitan site and OpenTitan docs for more information about the project.
This repository contains hardware, software and utilities written as part of the OpenTitan project. It is structured as monolithic repository, or “monorepo”, where all components live in one repository. It exists to enable collaboration across partners participating in the OpenTitan project.
The project contains comprehensive documentation of all IPs and tools. You can access it online at docs.opentitan.org.
Have a look at CONTRIBUTING and our documentation on project organization and processes for guidelines on how to contribute code to this repository.
Unless otherwise noted, everything in this repository is covered by the Apache License, Version 2.0 (see LICENSE for full text).