Google Git
Sign in
opensecura / 3p / lowrisc / opentitan / 561563f26ab8d5e693357d9abf74cb2d2b7ddf33
commit561563f26ab8d5e693357d9abf74cb2d2b7ddf33[log] [tgz]
authorRupert Swarbrick <rswarbrick@lowrisc.org>Wed Sep 15 17:43:44 2021 +0100
committerRupert Swarbrick <rswarbrick@gmail.com>Fri Sep 17 16:11:15 2021 +0100
tree64741547251e1f371fe00ec30ee1e3a1efc96075
parentddfe34165d67320829d863dece2ac01fe0966212 [diff]
[otbn,dv] Fix logic when picking operands for BN.SID

Model.regs_with_known_vals returns a list of pairs "(idx, value)".
Searching in known_wdrs[0] meant we were only able to pick reg_idx if
either reg_val was a known WDR that matched the first "idx" OR the
first known WDR happened to have a value that matched reg_val.

This caused a weird bug with the otbn_reset test where our behaviour
depended on the (architecturally unspecified) value of w0, accessed
through x0 when we happened to have another WDR (the first in
known_wdrs) that had a known value of zero.

While we're fixing things, weaken the check so we only require the
register to have an architecturally specified value: we don't actually
need the RIG to know what it is.

Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
1 file changed
tree: 64741547251e1f371fe00ec30ee1e3a1efc96075
  1. .github/
  2. ci/
  3. doc/
  4. hw/
  5. rules/
  6. site/
  7. sw/
  8. test/
  9. util/
  10. .bazelversion
  11. .clang-format
  12. .dockerignore
  13. .flake8
  14. .gitignore
  15. .style.yapf
  16. .svlint.toml
  17. .svls.toml
  18. _index.md
  19. apt-requirements.txt
  20. azure-pipelines.yml
  21. BUILD
  22. check_tool_requirements.core
  23. CLA
  24. COMMITTERS
  25. CONTRIBUTING.md
  26. LICENSE
  27. meson.build
  28. meson_init.sh
  29. meson_options.txt
  30. python-requirements.txt
  31. README.md
  32. tool_requirements.py
  33. toolchain.txt
  34. topgen-generator.core
  35. topgen-reg-only.core
  36. topgen.core
  37. WORKSPACE
  38. yum-requirements.txt
README.md

OpenTitan

OpenTitan logo

About the project

OpenTitan is an open source silicon Root of Trust (RoT) project. OpenTitan will make the silicon RoT design and implementation more transparent, trustworthy, and secure for enterprises, platform providers, and chip manufacturers. OpenTitan is administered by lowRISC CIC as a collaborative project to produce high quality, open IP for instantiation as a full-featured product. See the OpenTitan site and OpenTitan docs for more information about the project.

About this repository

This repository contains hardware, software and utilities written as part of the OpenTitan project. It is structured as monolithic repository, or “monorepo”, where all components live in one repository. It exists to enable collaboration across partners participating in the OpenTitan project.

Documentation

The project contains comprehensive documentation of all IPs and tools. You can access it online at docs.opentitan.org.

How to contribute

Have a look at CONTRIBUTING and our documentation on project organization and processes for guidelines on how to contribute code to this repository.

Licensing

Unless otherwise noted, everything in this repository is covered by the Apache License, Version 2.0 (see LICENSE for full text).