commit 499ad61256e6bf352abf98c17bc5ac7d2f556a53
author Sam Elliott <selliott@lowrisc.org> Mon Oct 05 19:27:55 2020 +0100
committer Sam Elliott <sam@lenary.co.uk> Wed Oct 07 15:43:02 2020 +0100
tree 184c5cc40aada9ecd2c06ec626c7ef24bbd4116c
parent 3eed4a77cd6d1ecbd0595020e51fccfe31bf1aa8

[sw] Ensure all switches have defaults

Signed-off-by: Sam Elliott <selliott@lowrisc.org>

meson.build

diff --git a/meson.build b/meson.build
index cb7871c..286e297 100644
--- a/meson.build
+++ b/meson.build
@@ -45,6 +45,8 @@
 # C compiler arguments to to catch common errors, used on all builds.
 extra_warning_args = [
   '-Wimplicit-fallthrough', # Error on implicit fallthrough
+  '-Wswitch-default', # Ensure all switches have default statements
+  '-Wno-covered-switch-default', # We require `default:` always.
 ]
 
 # C compiler arguments to optimize for size, used on cross builds only.

sw/device/benchmarks/coremark/top_earlgrey/ee_printf.c

diff --git a/sw/device/benchmarks/coremark/top_earlgrey/ee_printf.c b/sw/device/benchmarks/coremark/top_earlgrey/ee_printf.c
index b010cbd..210c9e2 100644
--- a/sw/device/benchmarks/coremark/top_earlgrey/ee_printf.c
+++ b/sw/device/benchmarks/coremark/top_earlgrey/ee_printf.c
@@ -506,6 +506,8 @@
       case '0':
         flags |= ZEROPAD;
         goto repeat;
+      default:
+        break;
     }
 
     // Get field width

sw/device/lib/usb_controlep.c

diff --git a/sw/device/lib/usb_controlep.c b/sw/device/lib/usb_controlep.c
index fbb20c2..9d4836e 100644
--- a/sw/device/lib/usb_controlep.c
+++ b/sw/device/lib/usb_controlep.c
@@ -149,6 +149,9 @@
       usbdev_buf_copyto_byid(ctx, buf, &zero, len);
       usbdev_sendbuf_byid(ctx, buf, len, ctctx->ep);
       return kCtWaitIn;
+
+    default:
+      return kCtError;
   }
   return kCtError;
 }

sw/device/tests/runtime/print_unittest.cc

diff --git a/sw/device/tests/runtime/print_unittest.cc b/sw/device/tests/runtime/print_unittest.cc
index 4013292..6e00af0 100644
--- a/sw/device/tests/runtime/print_unittest.cc
+++ b/sw/device/tests/runtime/print_unittest.cc
@@ -169,6 +169,9 @@
     case 8:
       EXPECT_EQ(buf_, "Hello, 0x0000000000001234!\n");
       break;
+    default:
+      FAIL() << "Unknown pointer size";
+      break;
   }
 }
 
@@ -181,6 +184,9 @@
     case 8:
       EXPECT_EQ(buf_, "Hello, 0x0000000000000000!\n");
       break;
+    default:
+      FAIL() << "Unknown pointer size";
+      break;
   }
 }