| commit | 4403ea1018da990b45044728a3df058f39023b0d | [log] [tgz] |
|---|---|---|
| author | Eunchan Kim <eunchan@opentitan.org> | Wed Sep 23 10:26:59 2020 -0700 |
| committer | Eunchan Kim <eunchan@opentitan.org> | Wed Sep 23 11:20:16 2020 -0700 |
| tree | b442764cc9c1f093d6ab8cf399f5258f71e4ab2d | |
| parent | c98098837a940deee5b774f848fb0f29b45496c6 [diff] |
[kmac] Revise incorrect Assertion
When process_latched asserted and it is not the end of the block, the
assertion is to check if internal padding logic to complete the block
size or not by checking keccak_valid_o signal. If the time is the end of
the block transfer, padding logic will trigger `run` first and will padd
th rest of the bits in next block.
Current assertion precondition was wrong. `!end_of_block ||
!sent_blocksize` is always 1 as `end_of_block` and `sent_blocksize` are
always one cycle apart.
WHy not detected earlier?:
In previous commits (PRs), FPV only tested SHA3-256 algorithm with
fixed data pattern (Empty, 1 Word, or 3 bytes). So there was no
chance to hit this corner case. However, in KMAC top-level test, it
doesn't bound the data pattern or algorithm mode/strength **yet**.
So, the FPV tool was able to catch this condition.
Signed-off-by: Eunchan Kim <eunchan@opentitan.org>
OpenTitan is an open source silicon Root of Trust (RoT) project. OpenTitan will make the silicon RoT design and implementation more transparent, trustworthy, and secure for enterprises, platform providers, and chip manufacturers. OpenTitan is administered by lowRISC CIC as a collaborative project to produce high quality, open IP for instantiation as a full-featured product. See the OpenTitan site and OpenTitan docs for more information about the project.
This repository contains hardware, software and utilities written as part of the OpenTitan project. It is structured as monolithic repository, or “monorepo”, where all components live in one repository. It exists to enable collaboration across partners participating in the OpenTitan project.
The project contains comprehensive documentation of all IPs and tools. You can access it online at docs.opentitan.org.
Have a look at CONTRIBUTING for guidelines on how to contribute code to this repository.
Unless otherwise noted, everything in this repository is covered by the Apache License, Version 2.0 (see LICENSE for full text).