commit 3c32208530d35cd7ee4eb620fbd9ba7fbc2639b7
author Cindy Chen <chencindy@google.com> Tue Mar 16 15:47:44 2021 -0700
committer cindychip <cindy.chen0316@gmail.com> Tue Mar 16 17:08:37 2021 -0700
tree 4f436b06e761615d0ed7905ffd56ff67e8d8fad8
parent ee8e16ed0ae1db26727341bb0fcf248aeea53366

[dv/common] Fix regression warnings

This PR fixes two warnings in regression:
1. Add a void cast when using predict function
2. Correct apply_reset input name in otp_ctrl dv

Signed-off-by: Cindy Chen <chencindy@google.com>

hw/dv/sv/dv_base_reg/dv_base_reg_field.sv

diff --git a/hw/dv/sv/dv_base_reg/dv_base_reg_field.sv b/hw/dv/sv/dv_base_reg/dv_base_reg_field.sv
index cda15fe..8886a67 100644
--- a/hw/dv/sv/dv_base_reg/dv_base_reg_field.sv
+++ b/hw/dv/sv/dv_base_reg/dv_base_reg_field.sv
@@ -50,7 +50,7 @@
     if (is_intr_test_fld) begin
       uvm_reg_field intr_state_fld = get_intr_state_field();
       // use UVM_PREDICT_READ to avoid uvm_warning due to UVM_PREDICT_DIRECT
-      intr_state_fld.predict(field_val | `gmv(intr_state_fld), .kind(UVM_PREDICT_READ));
+      void'(intr_state_fld.predict(field_val | `gmv(intr_state_fld), .kind(UVM_PREDICT_READ)));
     end
 
     super.do_predict(rw, kind, be);

hw/ip/otp_ctrl/dv/env/seq_lib/otp_ctrl_base_vseq.sv

diff --git a/hw/ip/otp_ctrl/dv/env/seq_lib/otp_ctrl_base_vseq.sv b/hw/ip/otp_ctrl/dv/env/seq_lib/otp_ctrl_base_vseq.sv
index 275a76c..42acfdd 100644
--- a/hw/ip/otp_ctrl/dv/env/seq_lib/otp_ctrl_base_vseq.sv
+++ b/hw/ip/otp_ctrl/dv/env/seq_lib/otp_ctrl_base_vseq.sv
@@ -31,8 +31,8 @@
   endtask
 
   // Cfg errors are cleared after reset
-  virtual task apply_reset(string reset_kind = "HARD");
-    super.apply_reset(reset_kind);
+  virtual task apply_reset(string kind = "HARD");
+    super.apply_reset(kind);
     cfg.ecc_err = OtpNoEccErr;
   endtask