commit 39362462b7adc685d15c81617912d6667dba0d72
author Rupert Swarbrick <rswarbrick@lowrisc.org> Thu Jun 04 15:26:17 2020 +0100
committer sriyerg <46467186+sriyerg@users.noreply.github.com> Thu Jun 11 10:24:37 2020 -0700
tree f5dc3048ab8095f06e3ccca07fca149b36ffc0d1
parent 09babd9d2dca7f8b8cc2ed74914acab0ad525105

[dvsim] Remove unnecessary getattr/setattr calls from SimCfg.py

getattr(object, 'name') is the same thing as object.name (unlike
dict.get, it raises an exception if there is no name field). Similarly
with setattr. Use the simpler and more idiomatic version.

Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>

util/dvsim/SimCfg.py

diff --git a/util/dvsim/SimCfg.py b/util/dvsim/SimCfg.py
index 79073c3..b1402e5 100644
--- a/util/dvsim/SimCfg.py
+++ b/util/dvsim/SimCfg.py
@@ -222,7 +222,7 @@
 
             # Use the default build mode for tests that do not specify it
             if not hasattr(self, "build_mode"):
-                setattr(self, "build_mode", "default")
+                self.build_mode = 'default'
 
             self._process_exports()
 
@@ -283,8 +283,7 @@
                 sys.exit(1)
 
         # Create tests from given list of items
-        tests = Tests.create_tests(getattr(self, "tests"), self)
-        setattr(self, "tests", tests)
+        self.tests = Tests.create_tests(self.tests, self)
 
         # Regressions
         # Parse testplan if provided.
@@ -294,9 +293,8 @@
             self.regressions.extend(self.testplan.get_milestone_regressions())
 
         # Create regressions
-        regressions = Regressions.create_regressions(
-            getattr(self, "regressions"), self, tests)
-        setattr(self, "regressions", regressions)
+        self.regressions = Regressions.create_regressions(self.regressions,
+                                                          self, self.tests)
 
     def _print_list(self):
         for list_item in self.list_items:
@@ -550,8 +548,7 @@
 
         # Add path to testplan.
         if hasattr(self, "testplan_doc_path"):
-            testplan = "https://" + self.doc_server + '/' + getattr(
-                self, "testplan_doc_path")
+            testplan = "https://" + self.doc_server + '/' + self.testplan_doc_path
         else:
             testplan = "https://" + self.doc_server + '/' + self.rel_path
             testplan = testplan.replace("/dv", "/doc/dv_plan/#testplan")
@@ -578,8 +575,7 @@
                     # Link the dashboard page using "cov_report_page" value.
                     if hasattr(self, "cov_report_page"):
                         results_str += "\n### [Coverage Dashboard]"
-                        results_str += "({})\n\n".format(
-                            getattr(self, "cov_report_page"))
+                        results_str += "({})\n\n".format(self.cov_report_page)
                     results_str += self.cov_report_deploy.cov_results
                     self.results_summary[
                         "Coverage"] = self.cov_report_deploy.cov_total