[dv/dvsim] Fix when next_item does not have dependency
This PR fixes the comment in PR #4993. Thanks @rupert for the
suggestion.
Signed-off-by: Cindy Chen <chencindy@google.com>
diff --git a/util/dvsim/Scheduler.py b/util/dvsim/Scheduler.py
index 95d8a36..d3f3458 100644
--- a/util/dvsim/Scheduler.py
+++ b/util/dvsim/Scheduler.py
@@ -101,7 +101,7 @@
# Does next_item have any dependencies? Since we dispatch jobs by
# target, we can assume that each of those dependencies appears
# in old_results.
- has_failed_dep = False if next_item.needs_all_dependencies_passing else True
+ has_failed_dep = False
for dep in next_item.dependencies:
dep_status = old_results[dep]
assert dep_status in ['P', 'F', 'K']
@@ -111,6 +111,10 @@
has_failed_dep = True
break
else:
+ # Set has_failed_dep default value to True only if the
+ # next_item has dependencies, and next_item does not require
+ # all dependencies to pass
+ has_failed_dep = True
if dep_status in ['P']:
has_failed_dep = False
break
