commit 21437af7303bc7f17fd7c0ba76d269a3289ba0e0
author Rupert Swarbrick <rswarbrick@lowrisc.org> Tue Dec 15 12:41:46 2020 +0000
committer Rupert Swarbrick <rswarbrick@gmail.com> Wed Dec 16 15:33:28 2020 +0000
tree f6da7e0d30054dfb2bcfc7e6b8d3dcde1bb63e82
parent 5238ecf89498f17009ac4a34ca023188627d7bee

[otbn] Fix is_dest check in rig

This code is supposed to check which operands are destinations (to see
whether we're seeing a read or a write). Unfortunately, I forgot the
parentheses for the function call, so was checking whether a function
was none or not (it isn't).

Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>

hw/ip/otbn/util/rig/model.py

diff --git a/hw/ip/otbn/util/rig/model.py b/hw/ip/otbn/util/rig/model.py
index 4784da4..5bad3f2 100644
--- a/hw/ip/otbn/util/rig/model.py
+++ b/hw/ip/otbn/util/rig/model.py
@@ -687,7 +687,7 @@
         for operand, op_val in zip(insn.operands, prog_insn.operands):
             op_type = operand.op_type
             if isinstance(op_type, RegOperandType):
-                if op_type.is_dest:
+                if op_type.is_dest():
                     pending_writes.append((op_type.reg_type, op_val))
                 else:
                     self.read_reg(op_type.reg_type, op_val)