commit 0449d2a77b54491d57f4c47af9f3f13c23a36486
author Fatih Balli <fatihballi@google.com> Wed Oct 12 10:57:56 2022 +0200
committer jadephilipoom <jadep@google.com> Wed Oct 12 10:06:53 2022 -0400
tree 17486132573c180d93fd16bc150efeda2f3138e9
parent a49528cf0b786dcacdd12df4eeebc4a0d4633d84

[kmac, dif] Fix dif_kmac_config_is_locked

Signed-off-by: Fatih Balli <fatihballi@google.com>

sw/device/lib/dif/dif_kmac.c

diff --git a/sw/device/lib/dif/dif_kmac.c b/sw/device/lib/dif/dif_kmac.c
index 8d344ce..7065627 100644
--- a/sw/device/lib/dif/dif_kmac.c
+++ b/sw/device/lib/dif/dif_kmac.c
@@ -774,7 +774,7 @@
 
   uint32_t reg =
       mmio_region_read32(kmac->base_addr, KMAC_CFG_REGWEN_REG_OFFSET);
-  *is_locked = bitfield_bit32_read(reg, KMAC_CFG_REGWEN_EN_BIT);
+  *is_locked = !bitfield_bit32_read(reg, KMAC_CFG_REGWEN_EN_BIT);
   return kDifOk;
 }
 

sw/device/lib/dif/dif_kmac_unittest.cc

diff --git a/sw/device/lib/dif/dif_kmac_unittest.cc b/sw/device/lib/dif/dif_kmac_unittest.cc
index 7e09120..4368017 100644
--- a/sw/device/lib/dif/dif_kmac_unittest.cc
+++ b/sw/device/lib/dif/dif_kmac_unittest.cc
@@ -588,7 +588,7 @@
 class ConfigLock : public KmacTest {};
 
 TEST_F(ConfigLock, Locked) {
-  EXPECT_READ32(KMAC_CFG_REGWEN_REG_OFFSET, true);
+  EXPECT_READ32(KMAC_CFG_REGWEN_REG_OFFSET, 0);
 
   bool lock = false;
   EXPECT_EQ(dif_kmac_config_is_locked(&kmac_, &lock), kDifOk);
@@ -596,7 +596,7 @@
 }
 
 TEST_F(ConfigLock, Unlocked) {
-  EXPECT_READ32(KMAC_CFG_REGWEN_REG_OFFSET, false);
+  EXPECT_READ32(KMAC_CFG_REGWEN_REG_OFFSET, 1);
 
   bool lock = true;
   EXPECT_EQ(dif_kmac_config_is_locked(&kmac_, &lock), kDifOk);