commit 019b67ed5061d2cdcf552d79270dd69ba69f3bdc
author Philipp Wagner <phw@lowrisc.org> Thu Aug 05 22:05:41 2021 +0100
committer Philipp Wagner <mail@philipp-wagner.com> Fri Aug 06 17:33:54 2021 +0100
tree 523092eeda42cac370bc43658f4e8c2923748a5b
parent 9ae1d1133bdeed072c15558a4b96ade0754d5e88

[otbn] Add zero reset values to bus-accessible registers

Signed-off-by: Philipp Wagner <phw@lowrisc.org>

hw/ip/otbn/data/otbn.hjson

diff --git a/hw/ip/otbn/data/otbn.hjson b/hw/ip/otbn/data/otbn.hjson
index adaf54d..8399bc8 100644
--- a/hw/ip/otbn/data/otbn.hjson
+++ b/hw/ip/otbn/data/otbn.hjson
@@ -178,6 +178,7 @@
       fields: [
         { bits: "0",
           name: "bad_data_addr"
+          resval: 0,
           desc: '''
             A DMEM read or write occurred with an out of bounds or unaligned
             address.
@@ -185,11 +186,13 @@
         }
         { bits: "1",
           name: "bad_insn_addr"
+          resval: 0,
           desc: '''
             An IMEM read occurred with an out of bounds or unaligned address.
           '''
         }
         { bits: "2",
+          resval: 0,
           name: "call_stack"
           desc: '''
             A instruction tried to pop from an empty call stack or push to a
@@ -197,6 +200,7 @@
           '''
         }
         { bits: "3",
+          resval: 0,
           name: "illegal_insn"
           desc: '''
             One of the following happened:
@@ -208,6 +212,7 @@
         }
         { bits: "4",
           name: "loop"
+          resval: 0,
           desc: '''
             One of the following happened:
             <ul>
@@ -224,14 +229,17 @@
         }
         { bits: "5",
           name: "fatal_imem"
+          resval: 0,
           desc: "A fatal error was seen on an instruction fetch."
         }
         { bits: "6",
           name: "fatal_dmem"
+          resval: 0,
           desc: "A fatal error was seen on a DMEM read."
         }
         { bits: "7",
           name: "fatal_reg"
+          resval: 0,
           desc: "A fatal error was seen on a GPR or WDR read."
         }
       ]
@@ -317,6 +325,7 @@
       fields: [
         { bits: "31:0",
           name: "insn_cnt",
+          resval: 0,
           desc: '''
             The number of instructions executed in the current or last OTBN run.
             Saturates at 2^32-1. The counter is reset to zero when a new operation

hw/ip/otbn/rtl/otbn_reg_pkg.sv

diff --git a/hw/ip/otbn/rtl/otbn_reg_pkg.sv b/hw/ip/otbn/rtl/otbn_reg_pkg.sv
index fc01705..34d75c8 100644
--- a/hw/ip/otbn/rtl/otbn_reg_pkg.sv
+++ b/hw/ip/otbn/rtl/otbn_reg_pkg.sv
@@ -167,6 +167,7 @@
   parameter logic [0:0] OTBN_CMD_RESVAL = 1'h 0;
   parameter logic [0:0] OTBN_STATUS_RESVAL = 1'h 0;
   parameter logic [31:0] OTBN_INSN_CNT_RESVAL = 32'h 0;
+  parameter logic [31:0] OTBN_INSN_CNT_INSN_CNT_RESVAL = 32'h 0;
 
   // Window parameters
   parameter logic [BlockAw-1:0] OTBN_IMEM_OFFSET = 16'h 4000;