Fix invalid dereference in the `Pointer` proxy. (#249)

This code does not compile, we are running into this issue because we
just started using it. Add a test to reproduce the issue and check for
basic behavior.

Signed-off-by: Hugo Lefeuvre <hugo.lefeuvre@scisemi.com>
Co-authored-by: Nathaniel Filardo <105816689+nwf-msr@users.noreply.github.com>

sdk/include/ds/pointer.h

diff --git a/sdk/include/ds/pointer.h b/sdk/include/ds/pointer.h
index de52755..598c726 100644
--- a/sdk/include/ds/pointer.h
+++ b/sdk/include/ds/pointer.h
@@ -113,7 +113,7 @@
 
 			__always_inline Pointer<T> &operator=(Pointer const &p)
 			{
-				ref = *p.ref;
+				ref = p.ref;
 				return *this;
 			}
 

tests/misc-test.cc

diff --git a/tests/misc-test.cc b/tests/misc-test.cc
index 13e1adf..3cbab21 100644
--- a/tests/misc-test.cc
+++ b/tests/misc-test.cc
@@ -3,6 +3,7 @@
 
 #define TEST_NAME "Test misc APIs"
 #include "tests.hh"
+#include <ds/pointer.h>
 #include <string.h>
 #include <timeout.h>
 
@@ -85,8 +86,35 @@
 	     "memchr must return NULL for zero-size pointers.");
 }
 
+/**
+ * Test pointer utilities.
+ *
+ * Not comprehensive, would benefit from being expanded at some point.
+ */
+void check_pointer_utilities()
+{
+	debug_log("Test pointer utilities.");
+
+	int                              integer        = 42;
+	int                             *integerPointer = &integer;
+	ds::pointer::proxy::Pointer<int> pointer{integerPointer};
+
+	TEST((pointer == integerPointer) && (*pointer == 42),
+	     "The pointer proxy does not return the value of its proxy.");
+
+	int                              anotherInteger        = -100;
+	int                             *anotherIntegerPointer = &anotherInteger;
+	ds::pointer::proxy::Pointer<int> anotherPointer{anotherIntegerPointer};
+
+	pointer = anotherPointer;
+
+	TEST((pointer == anotherIntegerPointer) && (*pointer == -100),
+	     "The pointer proxy `=` operator does not correctly set the pointer.");
+}
+
 void test_misc()
 {
 	check_timeouts();
 	check_memchr();
+	check_pointer_utilities();
 }