commit 44cd0676ce8668833897739c47cdbab6158dfb87
author Alex Van Damme <atv@google.com> Wed Sep 18 20:40:16 2024 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Wed Sep 18 20:40:16 2024 +0000
tree c0c5270411876937dbf4c80c7093707e0e56234a
parent 9b9216a19fb235efcd8191686632391c3d18e212
parent 5da35fbd7b2c512ae15cc1d7218b04cbda6230db

Merge "Fix kelvin fpga_tests"

sw/device/tests/kelvin/fpga_tests/kelvin_test_smc.c

diff --git a/sw/device/tests/kelvin/fpga_tests/kelvin_test_smc.c b/sw/device/tests/kelvin/fpga_tests/kelvin_test_smc.c
index 197f259..2c8cf63 100644
--- a/sw/device/tests/kelvin/fpga_tests/kelvin_test_smc.c
+++ b/sw/device/tests/kelvin/fpga_tests/kelvin_test_smc.c
@@ -68,6 +68,11 @@
       mmio_region_t base_addr =
           mmio_region_from_addr(TOP_MATCHA_ML_TOP_CORE_BASE_ADDR);
       // Reset and halt Kelvin
+      // NB: Kelvin needs a few cycles in reset with a clock,
+      // so set the reset bit and the gate in two transactions.
+      mmio_region_write32(
+          base_addr, ML_TOP_CTRL_REG_OFFSET,
+          ML_TOP_CTRL_REG_RESVAL);
       mmio_region_write32(
           base_addr, ML_TOP_CTRL_REG_OFFSET,
           ML_TOP_CTRL_REG_RESVAL | (1 << ML_TOP_CTRL_FREEZE_BIT));