docs: Update code review policy Update the stickyness of the code review scores. Change-Id: I4b1fe49e65e29b895fd4bd74f56860cf51ec0342
diff --git a/GettingStarted.md b/GettingStarted.md index c2b056f..7122ce1 100644 --- a/GettingStarted.md +++ b/GettingStarted.md
@@ -87,25 +87,25 @@ In the Shodan project, we follow a "sticky +2" policy. What this means is that you *must* get a +2 Code Review from a peer, or a TL. -Gerrit will automatically remove any +2 Code Review scores you receive when you -upload a patchset. In this case, once a peer has given you a +2 Code Review, you -are free to re-+2 your change yourself if the changes are minor or otherwise -address comments in the CL. +Gerrit will automatically pass any +2 Code Review scores you receive when you +upload a patchset with minor changes. This policy is in place so that we can +quickly get through code review and get our code submitted without requiring +lots of round-trips with your reviewers. If you change significant parts of the CL post-+2, please ask for additional review from your peers in a reply. Note: two +1s does *not* count as a +2! -You may *not* self-+2 your own CLs, no matter the urgency or how simple the -change is! Resist the temptation! This policy is in place so that we can quickly -get through code review and get our code submitted without requiring lots of -round-trips with your reviewers. +You can't self-+2 your own CL, no matter the urgency or how simple the +change is! This policy ensures the code change is peer reviewed, and prevent us +from getting in trouble with security/compliance. If you don't know who to send +a CL to, put one of the TLs on the review list, and they'll redirect it +appropriately, or review your change. -Please don't abuse this policy and use good judgement: if you don't know who to -send a CL to, put one of the TLs on the review list, and they'll redirect it -appropriately, or review your change. If we abuse the policy by +2-ing before -peer review, this privilige will unfortunately have to be revoked, slowing down -the entire team in the process, and possibly getting yourself in trouble with -security/compliance. +As a reviewer, please use good judgement to help the team keep the good +momentum: If you provide a +1 score, please note in your comment who should +provide the +2; if your comments are minor changes about style, format, etc., +and not related to the functionality of the code, please provide +2 so the code +owner can address the comments and submit the code without further review. ### Who are the TLs?