commit e22bc2b6e9a335ab7140a92ac85f1cf6f3ea128e
author Woyten <woyten.tielesch@online.de> Fri Jan 17 14:12:47 2020 +0100
committer Woyten <woyten.tielesch@online.de> Sat Jan 18 18:48:13 2020 +0100
tree 8a9c36ba85d714ac8adddc7b73073e2ad842e89f
parent d007bb9300b43c90625491e231792115aa5f412e

Review comments

src/buttons.rs

diff --git a/src/buttons.rs b/src/buttons.rs
index 5787f83..aac5cb2 100644
--- a/src/buttons.rs
+++ b/src/buttons.rs
@@ -1,6 +1,7 @@
 use crate::callback::CallbackSubscription;
 use crate::callback::Consumer;
 use crate::result::OtherError;
+use crate::result::OutOfRangeError;
 use crate::result::TockResult;
 use crate::syscalls;
 use core::marker::PhantomData;
@@ -41,14 +42,15 @@
         self.num_buttons
     }
 
-    pub fn get(&self, button_num: usize) -> Option<Button> {
+    /// Returns the button at 0-based index `button_num`
+    pub fn get(&self, button_num: usize) -> Result<Button, OutOfRangeError> {
         if button_num < self.num_buttons {
-            Some(Button {
+            Ok(Button {
                 button_num,
                 lifetime: PhantomData,
             })
         } else {
-            None
+            Err(OutOfRangeError)
         }
     }