commit 0e1ba0a7b1357762b2eca69448f21ed69f38cb0a
author Alistair Francis <alistair.francis@wdc.com> Wed Mar 25 16:00:06 2020 -0700
committer Alistair Francis <alistair.francis@wdc.com> Fri Mar 27 15:08:13 2020 -0700
tree dbee2e395e67b987b4c6d2d307ddac8946612445
parent b0d94d9773f33ce40454fe6dfebe6426b77672c4

core/entry_point: Start the heap at app_heap_break

Start the app's head size at the value of app_head_break passed by the
kernel.

This gives us more space to work with which allows us to create large
buffers (such as for passing to/from the HMAC).

It also means we do what the kernel expects us to do

Signed-off-by: Alistair Francis <alistair.francis@wdc.com>

core/src/entry_point/mod.rs

diff --git a/core/src/entry_point/mod.rs b/core/src/entry_point/mod.rs
index c2628e1..40bdb62 100644
--- a/core/src/entry_point/mod.rs
+++ b/core/src/entry_point/mod.rs
@@ -84,7 +84,7 @@
 /// into the rustc-generated main(). This cannot use mutable global variables or
 /// global references to globals until it is done setting up the data segment.
 #[no_mangle]
-unsafe extern "C" fn rust_start(app_start: usize, stacktop: usize, _app_heap_break: usize) -> ! {
+unsafe extern "C" fn rust_start(app_start: usize, stacktop: usize, app_heap_start: usize) -> ! {
     extern "C" {
         // This function is created internally by `rustc`. See
         // `src/lang_items.rs` for more details.
@@ -122,9 +122,6 @@
     // We get this from the environment to make it easy to set per compile.
     let app_heap_size: usize = read_APP_HEAP_SIZE();
 
-    // Make the heap start exactly at bss_end. The suggested _app_heap_break
-    // is almost always going to be too big and leads to us wasting memory.
-    let app_heap_start = bss_end;
     let app_heap_end = app_heap_start + app_heap_size;
 
     // Tell the kernel the new app heap break.