)]}'
{
  "commit": "fe8389b5129c08d4d12d5749ed65d55b6760b3da",
  "tree": "dd57edcfe60605585a0a96bad1f99052390c9dcd",
  "parents": [
    "616b7e54bd9c630379ca0dbcd2de09b76b43b825"
  ],
  "author": {
    "name": "Geoffrey Martin-Noble",
    "email": "gcmn@google.com",
    "time": "Tue Jan 28 15:00:09 2020 -0800"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Tue Jan 28 15:01:20 2020 -0800"
  },
  "message": "Bazel to CMake: use explicit kwargs\n\nMake kwargs in bazel to cmake functions explicit. This is more robust and less fiddly. There\u0027s some question of whether we should mirror the default values from the .bzl file here or rely on the cmake rule implementation having the right defaults. I went with the former for now because the only downside is redundant specifications in the cmake file, which seems not bad. We might want to remove the defaults in cmake if we go to fully generated files, since then it\u0027s one less place to keep in sync.\n\nTested:\nRan this in preview mode across the entire project and didn\u0027t see any new errors\n```\n$ ./build_tools/scripts/bazel_to_cmake.py --preview | grep -i error\n  Reason: `NameError: name \u0027platform_trampoline_deps\u0027 is not defined`\n    \"status_errors.h\"\n    \"status_win32_errors.h\"\n    \"status_errors.cc\"\n    \"status_win32_errors.cc\"\n  Reason: `NameError: name \u0027iree_flatbuffer_cc_library\u0027 is not defined`\n  Reason: `NameError: name \u0027PLATFORM_VULKAN_TEST_DEPS\u0027 is not defined`\n  Reason: `NameError: name \u0027PLATFORM_VULKAN_LOADER_COPTS\u0027 is not defined`\n  Reason: `KeyError: \"No conversion found for target \u0027//third_party/dawn:dawn_headers\u0027\"`\n  Reason: `NameError: name \u0027platform_trampoline_deps\u0027 is not defined`\n  Reason: `KeyError: \u0027@llvm-project//llvm:tablegen\u0027`\n  Reason: `NameError: name \u0027PLATFORM_VULKAN_DEPS\u0027 is not defined`\n  Reason: `NameError: name \u0027PLATFORM_VULKAN_TEST_DEPS\u0027 is not defined`\n  Reason: `KeyError: \"No conversion found for target \u0027@dear_imgui\u0027\"`\n```\n\nCloses https://github.com/google/iree/pull/589\n\nCOPYBARA_INTEGRATE_REVIEW\u003dhttps://github.com/google/iree/pull/589 from GMNGeoffrey:bazel-to-cmake-1-kwarg-cleanup 30fa731a914d195de3fcbd8912f2c0a4f67f90ec\nPiperOrigin-RevId: 292020535\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "4918d6fef51969919889c77395b6228b1d8471a0",
      "old_mode": 33261,
      "old_path": "build_tools/scripts/bazel_to_cmake.py",
      "new_id": "500bdbd60b1292d8cfef052bec51c0496ab753dc",
      "new_mode": 33261,
      "new_path": "build_tools/scripts/bazel_to_cmake.py"
    }
  ]
}