)]}'
{
  "commit": "fdc340ed5a99b2b924fa6a45ff1eea70c5fe6473",
  "tree": "666b0e34414fee3a65a6531f63d90183d3305e24",
  "parents": [
    "8da14f8a89d45ce242fb1772db2c81a576788d74"
  ],
  "author": {
    "name": "bjacob",
    "email": "benoitjacob@google.com",
    "time": "Mon Dec 05 17:00:24 2022 -0500"
  },
  "committer": {
    "name": "GitHub",
    "email": "noreply@github.com",
    "time": "Mon Dec 05 17:00:24 2022 -0500"
  },
  "message": "ukernel tweaks (#11280)\n\n- Remove validation code from non-validation builds, including in\r\ncallers (vmvx module entry points).\r\n  - Consistently enclose validation code in `IREE_UK_ENABLE_VALIDATION`\r\n  - Instead of going to `NDEBUG` everytime.\r\n- When validation is not enabled, do not even define the enum values\r\nbesides `status_ok`).\r\n- This allows to assume unreachability of `if(status !\u003d status_ok)`\r\n(since the other enum values don\u0027t even exist at compile time, the only\r\nway to return them would be some likely unintentional type punning, and\r\nsince the only enum value is 0, it\u0027s probably UB anyway for any other\r\nvalue to be represented by that enum).\r\n- On AArch64, this saves 50--100 bytes of code (plus rodata for the\r\ncaller\u0027s status message format string) per caller (e.g.\r\n`iree_vmvx_mmt4d`, `iree_vmvx_pack`, etc --- this is multiplied by the\r\nnumber of entry points that call ukernels, which could grow large) plus\r\nthe constant savings of code plus rodata for the literal strings in\r\n`iree_uk_status_message`. At the moment, this is overall a ~ 500 bytes\r\nsaving.\r\n- Rename PACK to TIE, UNPACK to UNTIE for the helpers munging together\r\n8bit type IDs into 16bit/32bit words. Was confusing with pack/unpack\r\nukernels.\r\n- Move attributes/builtins checks up in `common.h`.\r\n- Move `iree_uk_memset` to `common.h` (now a true memset, was\r\n`iree_uk_memset_zero`. Checked that that doesn\u0027t affect compilation).",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "940f363f21a36e4a57f4f8267452137d0b458fed",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/common.c",
      "new_id": "86af4c6f518f34433671e53d2344cbf5dcd2a847",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/common.c"
    },
    {
      "type": "modify",
      "old_id": "5a04e3bf48f93c5617437863ba2f4fb517bf2306",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/common.h",
      "new_id": "f5e5c13282b744d8792e73264506965857afc386",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/common.h"
    },
    {
      "type": "modify",
      "old_id": "1e5cb9dd2743c40d618a6db48317a7a9cc29b0b6",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/mmt4d.c",
      "new_id": "cb3364a1f7fb3d4e235be9643778bf5fd5060b47",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/mmt4d.c"
    },
    {
      "type": "modify",
      "old_id": "2c2397b89a9ebbc902d23064275a32b2038cc0f3",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/mmt4d_types.h",
      "new_id": "723723f4e24396bf15b3a9ef613acad4ae93fb2f",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/mmt4d_types.h"
    },
    {
      "type": "modify",
      "old_id": "10c06b6a3f834475c917d79f7db9905252bde05b",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/pack.c",
      "new_id": "7a1ce3af650464ace8ce1bb46377c2cacb577221",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/pack.c"
    },
    {
      "type": "modify",
      "old_id": "fdc77904cc921a71777b8fe6cb6a4c1eba83400c",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/pack_types.h",
      "new_id": "f0c4bc5d2a5b53c897addcad607c97fd010ff8e1",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/pack_types.h"
    },
    {
      "type": "modify",
      "old_id": "e7e77d4f582254c252894bf16bc450ab9f16252e",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/tools/ukernel_test_utils.cc",
      "new_id": "9e5211a7bd4c8e5b6db4a49a3c8a2f6f379c88e9",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/tools/ukernel_test_utils.cc"
    },
    {
      "type": "modify",
      "old_id": "ee5ea1afb75d4f0344f7f0033cb22d5cf3f0fbef",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/unpack.c",
      "new_id": "bf6fdbac4dd292c418f20f30530b906cf062a48d",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/unpack.c"
    },
    {
      "type": "modify",
      "old_id": "1a88d77bbf4ab4c7012ab15f18e2f994af10e68b",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/unpack_types.h",
      "new_id": "472b82082c8da0e20f0ddccf8e686a9e9fd2bec5",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/unpack_types.h"
    }
  ]
}
