tree 70250c6716f1cf9ba2723199f45d8c1cad2d096f
parent e43aaf54aa59924a8cab4f92354c65c0fe5df9aa
author Alex Vasile <48962821+Alex-Vasile@users.noreply.github.com> 1782737749 -0400
committer GitHub <noreply@github.com> 1782737749 +0200
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJqQmtVCRC1aQ7uu5UhlAAABVkQADyy98UoPczin5sKQOlG+iHD
 Y8J5A1zn+/bm1wyLFekdaPh8lM7tHPwBoV+JG0RddY/G4nXEQr1skfnZLOEakUgP
 2DQakO+Ogj/noCqwZrsGst7J0GBDEVxyO5U8QNkvaWSIVV7Xb1GZxVvV2jEMJ5p+
 b7ipWMuM9vhmUXp6esMgjMybaI7Memlgzam+9SRlbdCbkuUiP6uCGg6ekQAjxWtL
 GeBQEK6YBcVZXZUd1OT6//lr5qW32BEUsJrmmAQfvC7ipDeWnJJv4zPAFbRVmcBF
 cyOjW7r5UIkkO2Jq5NLAq33WqSiAI2zQ367s4DrlWl9iMdESlALkQyocojhHoNsk
 btsnRI0TIa6Gk8p8s0o1zcUoRttY5js7NGWA9S8NmXgbjhfW/RVMbm1ye6xAaSFx
 D8tEe0eD8OpCyLpGfW/5Gs/vk34tUWiTlngXw1gfc4nYD6ONLnB94hxMBhv9tvl3
 jppaZZfFoFfJM8A3QdukZ5n9tk1O4AUl40x8AfPW3H4yGmuzg08f250szAPBqC78
 saodet1wRu0Mpx6AWudwTKcqkFZN1OIXxsL7WpEtNoi0rA5WYEDq/rLTxMTpoGp/
 jBRZvOaU1S5s+XPrTZhWNPbLwwsuuYwBlH/dEBlB6UJtmpX7RVNww8m5OfxW1OL4
 2I2nZijZOEkmE+nwAQ3B
 =ygC+
 -----END PGP SIGNATURE-----
 

[Metal] Carry export name separately from MSL entry point for name lookup (#24642)

spirv-cross rewrites SPIR-V entry point names to be legal MSL/C
identifiers when serializing Metal executables: '.' characters (codegen
dispatch names like _dot_general_matmul_i32.i32.i32_...) become '_', and
reserved '__' prefixes (stream builtins like __builtin_splat_i64) are
dropped. The MetalSPIRV target stored only the rewritten MSL function
name in PipelineDef.entry_point, and the runtime loaded pipeline->name
from that same field -- so hal.executable.lookup.function, which
references the original un-rewritten hal.executable.export symbol name,
could never match for any export whose name spirv-cross rewrites. This
broke every metal-spirv e2e test using such exports
(dot/dot_general/convolution matmul kernels and
compare/dynamic_slice/gather stream builtins).

Add a dedicated always-present name field to PipelineDef carrying the
canonical hal.executable.export symbol name (populated from
exportOp.getName() in the compiler), appended at the end of the table
for backward-compatible vtable layout. The runtime now sources
pipeline->name (used by lookup_function_by_name) from this field,
keeping entry_point as the MTLFunction name for -[MTLLibrary
newFunctionWithName:]. The loader falls back to entry_point when name is
absent for compatibility.

Verified: dot_general (8/8), compare (15/15), and the full Metal CTS
suite
(command_buffer_tests/queue_tests/dispatch_tests/queue_dispatch_tests,
4/4) pass. Signed-off-by: Alex Vasile
<48962821+Alex-Vasile@users.noreply.github.com>

Signed-off-by: Alex Vasile <48962821+Alex-Vasile@users.noreply.github.com>