)]}'
{
  "commit": "f66d7f2acfba9f9e5e1e5d19f49da54a3bf4228a",
  "tree": "e681159e30ad734dd5642338ca5288272bffb58a",
  "parents": [
    "5218ef2de07b21ed4284024c74cf947ed95c11a5"
  ],
  "author": {
    "name": "Benoit Jacob",
    "email": "jacob.benoit.1@gmail.com",
    "time": "Fri Mar 01 23:13:33 2024 -0500"
  },
  "committer": {
    "name": "GitHub",
    "email": "noreply@github.com",
    "time": "Sat Mar 02 04:13:33 2024 +0000"
  },
  "message": "Fix enablement of mmt4d ukernel test cases based on ISA code paths built (#16637)\n\nThis fixes `build_test_all_windows` CI and adds CI configuration to\r\ntrigger it on all ukernel code changes going forward.\r\n\r\nThere is an unresolved mystery as to what exactly went wrong on\r\n`build_test_all_windows` CI job, as its MSVC compiler failed the\r\n`check_cxx_compile_flags` for `/arch:AVX2` while the exact same MSVC\r\nversion succeeded in the `build_test_runtime_windows` CI job.\r\n\r\nBut regardless, there was something not well thought out in how I did\r\nthe testcase enablement. I had added a global constant bool indicating\r\nwhether we had linked architecture-specific code, but that was only\r\nper-architecture, not accounting for the fact that, depending on\r\n`check_cxx_compile_flags`, some sub-architecture code paths could be\r\nindividually disabled.\r\n\r\nThis new PR redoes that: the global constant bools are dropped, and\r\ninstead, the problem is tackled differently in `mmt4d_test` vs\r\n`mmt4d_benchmark`:\r\n* In `mmt4d_test`, as we really want to avoid testcases silently testing\r\nnothing, we keep running *without fallback*, but we now condition\r\ntestcases on `IREE_UK_BUILD_*` cmake-defined variables.\r\n* In `mmt4d_benchmark`, we just enable the fallback, so in the worst\r\ncase if a code path is disabled, the outcome is a poor benchmark result.\r\n`mmt4d_benchmark` doesn\u0027t need to catch enablement, that\u0027s already done\r\nby `mmt4d_test`.",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "9959b15d40429ea4eed46e815bb2696a4a1b257c",
      "old_mode": 33261,
      "old_path": "build_tools/github_actions/configure_ci.py",
      "new_id": "215b679282b63a688a32d6199a5b7bc38e5c732b",
      "new_mode": 33261,
      "new_path": "build_tools/github_actions/configure_ci.py"
    },
    {
      "type": "modify",
      "old_id": "198e8b01c8c88723864fb031ccb1742538c1c26b",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/arch/arm_64/mmt4d_arm_64_entry_point.c",
      "new_id": "61ad8f9e0dbc0ebf96b89bb8de1d8fbeb5a432f0",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/arch/arm_64/mmt4d_arm_64_entry_point.c"
    },
    {
      "type": "modify",
      "old_id": "90d96bc061c719d662fb5436f958fa79d71721f7",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/arch/x86_64/mmt4d_x86_64_entry_point.c",
      "new_id": "153b96e499a36c7aa6b26b4c4dd773cb60f200c7",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/arch/x86_64/mmt4d_x86_64_entry_point.c"
    },
    {
      "type": "modify",
      "old_id": "6eb2ad5a9676bbac190906ffd264b2ae1971220f",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/fallback.c",
      "new_id": "eaee5b2e02e5731507b8c878e069924fc8797e10",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/fallback.c"
    },
    {
      "type": "modify",
      "old_id": "450e44d00b1b036dd175ae1d24e1449cb60e4624",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/mmt4d_internal.h",
      "new_id": "88417284d229a2930aba05633ca80457e03232ec",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/mmt4d_internal.h"
    },
    {
      "type": "modify",
      "old_id": "6dcd7e6269480a73b16d9a9b94fa7142383e3b9e",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/tools/mmt4d_benchmark.c",
      "new_id": "bfb932e4461adb72cb9d16d8dbd1926bb191701c",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/tools/mmt4d_benchmark.c"
    },
    {
      "type": "modify",
      "old_id": "974afb6f332767e472baec9ef952eb8984a0a0ba",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/tools/mmt4d_test.c",
      "new_id": "370930ab970b7f4a6cc41d505c37cada1304b905",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/tools/mmt4d_test.c"
    }
  ]
}