commit f6490969998ed021595fdcdd88400ddbc147581a
author Scott Todd <scotttodd@google.com> Tue Mar 29 10:05:13 2022 -0700
committer GitHub <noreply@github.com> Tue Mar 29 10:05:13 2022 -0700
tree 40f42cc261f108c1708f4f6f497ce5833473330b
parent 2cf4a787ad631be33b092eaf65223252fd63eab8

Fix web sample warnings and use IREE_DEFAULT_COPTS warnings/errors. (#8672)

Tested on Windows with emsdk 3.1.8

---

Warnings are now treated as errors thanks to applying `IREE_DEFAULT_COPTS`. I hesitate to use an internal IREE CMake variable in a sample, but the convenience seems worth it here. Anyone forking this can just set the options they want.

---

Mismatched pointer type was from https://github.com/google/iree/pull/8436 (since these don't build/test on presubmit and warnings were not treated as errors before). These samples now match https://github.com/google/iree/blob/2cf4a787ad631be33b092eaf65223252fd63eab8/iree/samples/static_library/static_library_demo.c#L33-L41

---

The `-sMAIN_MODULE=2` change is to fix this warning:

```
[10/10] Linking C executable experimental\web\sample_dynamic\web-sample-dynamic-sync.js
emcc: warning: EXPORTED_FUNCTIONS is not valid with LINKABLE set (normally due to SIDE_MODULE=1/MAIN_MODULE=1) since all functions are exported this mode.  To export only a subset use SIDE_MODULE=2/MAIN_MODULE=2 [-Wunused-command-line-argument]
```

See the docs: https://emscripten.org/docs/compiling/Dynamic-Linking.html#code-size. Setting to `2` enables DCE and `EXPORTED_FUNCTIONS` again (we tightly control the symbols we need so the default export all behavior isn't what we want).