Bazel to CMake: Add submit-blocking phrase to unimplemented function.
This should prevent non-strict runs of bazel_to_cmake from getting checked in accidentally.
PiperOrigin-RevId: 299419943
diff --git a/build_tools/bazel_to_cmake/bazel_to_cmake.py b/build_tools/bazel_to_cmake/bazel_to_cmake.py
index 82687a9..85acb5a 100755
--- a/build_tools/bazel_to_cmake/bazel_to_cmake.py
+++ b/build_tools/bazel_to_cmake/bazel_to_cmake.py
@@ -57,6 +57,7 @@
help="Prints results instead of writing files",
action="store_true",
default=False)
+ # TODO(b/149926655): Invert the default to be strict and rename this flag.
parser.add_argument(
"--strict",
help="Does not try to generate files where it cannot convert completely",
@@ -289,7 +290,12 @@
}
if not self.converter.first_error:
self.converter.first_error = NotImplementedError(message)
- self.converter.body += "# %s\n" % (message,)
+ # Avoid submitting the raw results from non-strict runs. These are still
+ # useful but are generally not safe to submit as-is. An upstream check
+ # prevents changes with this phrase from being submitted.
+ # Written as separate literals to avoid the check triggering here.
+ submit_blocker = "DO" + " NOT" + " SUBMIT."
+ self.converter.body += "# %s %s\n" % (submit_blocker, message)
# ------------------------------------------------------------------------- #
# Function handlers that convert BUILD definitions to CMake definitions. #
