commit e5774c30ce72b3ca099c9302fc343349124f7aa4
author Ben Vanik <benvanik@google.com> Sun Nov 15 17:06:09 2020 -0800
committer Ben Vanik <benvanik@google.com> Fri Nov 20 15:53:16 2020 -0800
tree 8ecb9a7310b1c6f19ffaf1ac7fd442d50d6e0ec0
parent 22d16b4da7a7e8d74aa5d371da244a4d6d38ab34

Remove unused args from flatbuffers_c_library macro.

build_tools/cmake/flatbuffer_c_library.cmake

diff --git a/build_tools/cmake/flatbuffer_c_library.cmake b/build_tools/cmake/flatbuffer_c_library.cmake
index e674c86..8435980 100644
--- a/build_tools/cmake/flatbuffer_c_library.cmake
+++ b/build_tools/cmake/flatbuffer_c_library.cmake
@@ -21,10 +21,6 @@
 # Parameters:
 # NAME: name of target (see Note)
 # SRCS: List of source files for the library
-# DEPS: List of other libraries to be linked in to the binary targets
-# COPTS: List of private compile options
-# DEFINES: List of public defines
-# LINKOPTS: List of link options
 # FLATCC_ARGS: List of flattbuffers arguments. Default:
 #             "--common"
 #             "--reader"
@@ -39,32 +35,28 @@
 #
 # flatbuffer_c_library(
 #   NAME
-#     base_schema
+#     some_def
 #   SRCS
-#     "a.fbs"
-# )
-# flatbuffer_c_library(
-#   NAME
-#     other_schemas
-#   SRCS
-#     "b.fbs"
-#   DEPS
-#     iree::schemas::base_schema
+#     "some_def.fbs"
+#   FLATCC_ARGS
+#     "--reader"
+#     "--builder"
+#     "--verifier"
+#     "--json"
 #   PUBLIC
 # )
-#
 # iree_cc_binary(
 #   NAME
 #     main_lib
 #   ...
 #   DEPS
-#     iree::schemas::other_schemas
+#     iree::schemas::some_def
 # )
 function(flatbuffer_c_library)
   cmake_parse_arguments(_RULE
     "PUBLIC;TESTONLY"
     "NAME"
-    "SRCS;COPTS;DEFINES;LINKOPTS;DEPS;FLATCC_ARGS"
+    "SRCS;FLATCC_ARGS"
     ${ARGN}
   )
 
@@ -128,7 +120,6 @@
     ${_GEN_TARGET}
     DEPENDS
       ${_OUTS}
-      ${_RULE_DEPS}
   )
 
   add_library(${_NAME} INTERFACE)
@@ -142,11 +133,6 @@
     INTERFACE
       flatcc::runtime
       ${IREE_DEFAULT_LINKOPTS}
-      ${_RULE_LINKOPTS}
-  )
-  target_compile_definitions(${_NAME}
-    INTERFACE
-      ${_RULE_DEFINES}
   )
   target_compile_options(${_NAME}
     INTERFACE