commit db7974c26549e3700923244ac1847b032013f898
author Markus Böck <markus.boeck02@gmail.com> Tue Jun 11 16:21:13 2024 +0200
committer GitHub <noreply@github.com> Tue Jun 11 16:21:13 2024 +0200
tree 7549575ae9c0cff2655758504095573b1a69076c
parent cda3ccb052be5aa81e3a3e7f5683b9ba39a8e55b

[util] Add serialization support for `f64` resources (#17640)

Serializing `f64` resources was strangely omitted from the logic while
`f32` and `f16` support is present. Running things with `f64` is
certainly not a good idea in general but relatively well-supported in
the LLVM backend. Our use-case is the bring-up of a custom compiler
backend where `f64` happens to be the most trivial element type to
support.

Signed-off-by: Markus Böck <markus.boeck02@gmail.com>

compiler/src/iree/compiler/Dialect/Util/IR/UtilAttrs.cpp

diff --git a/compiler/src/iree/compiler/Dialect/Util/IR/UtilAttrs.cpp b/compiler/src/iree/compiler/Dialect/Util/IR/UtilAttrs.cpp
index 03cc0f4..24007d7 100644
--- a/compiler/src/iree/compiler/Dialect/Util/IR/UtilAttrs.cpp
+++ b/compiler/src/iree/compiler/Dialect/Util/IR/UtilAttrs.cpp
@@ -469,13 +469,14 @@
              << " for type " << resourceElementsAttr.getType();
     }
   } else if (auto floatType = llvm::dyn_cast<FloatType>(elementType)) {
-    // TODO(saienduri): implement float64 support (not necessary now)
     unsigned bitWidth = floatType.getIntOrFloatBitWidth();
     switch (bitWidth) {
     case 16:
       return serializeResourceRawData(loc, resourceElementsAttr, os);
     case 32:
       return serializeResourceRawData(loc, resourceElementsAttr, os);
+    case 64:
+      return serializeResourceRawData(loc, resourceElementsAttr, os);
     default:
       return emitError(loc) << "unhandled float element bit width " << bitWidth
                             << " for type " << resourceElementsAttr.getType();

compiler/src/iree/compiler/Dialect/VM/Target/Bytecode/test/constant_encoding.mlir

diff --git a/compiler/src/iree/compiler/Dialect/VM/Target/Bytecode/test/constant_encoding.mlir b/compiler/src/iree/compiler/Dialect/VM/Target/Bytecode/test/constant_encoding.mlir
index 143ef6c..52f160c 100644
--- a/compiler/src/iree/compiler/Dialect/VM/Target/Bytecode/test/constant_encoding.mlir
+++ b/compiler/src/iree/compiler/Dialect/VM/Target/Bytecode/test/constant_encoding.mlir
@@ -182,4 +182,32 @@
   // CHECK-NEXT:   1
   // CHECK-NEXT: ]
   vm.rodata private @byte_pattern_i2 #util.byte_pattern<1> : tensor<9xi2>
+
+    //      CHECK: "embedded_data": [
+    // CHECK-NEXT:   0,
+    // CHECK-NEXT:   0,
+    // CHECK-NEXT:   0,
+    // CHECK-NEXT:   0,
+    // CHECK-NEXT:   0,
+    // CHECK-NEXT:   0,
+    // CHECK-NEXT:   240,
+    // CHECK-NEXT:   63,
+    // CHECK-NEXT:   0,
+    // CHECK-NEXT:   0,
+    // CHECK-NEXT:   0,
+    // CHECK-NEXT:   0,
+    // CHECK-NEXT:   0,
+    // CHECK-NEXT:   0,
+    // CHECK-NEXT:   0,
+    // CHECK-NEXT:   64,
+    // CHECK-NEXT:   0,
+    // CHECK-NEXT:   0,
+    // CHECK-NEXT:   0,
+    // CHECK-NEXT:   0,
+    // CHECK-NEXT:   0,
+    // CHECK-NEXT:   0,
+    // CHECK-NEXT:   8,
+    // CHECK-NEXT:   64
+    // CHECK-NEXT: ]
+    vm.rodata private @dense_f64 dense<[1.000000e+00, 2.000000e+00, 3.000000e+00]> : tensor<3xf64>
 }