commit d643f673aec8bdc0b1efcaee31397a5fe856421f
author Lei Zhang <antiagainst@google.com> Tue Jun 16 10:56:41 2020 -0400
committer Lei Zhang <antiagainst@google.com> Tue Jun 16 10:56:41 2020 -0400
tree 20a2217113c82e83c3834ac93a0beb2fd66ccf63
parent b6240f8a6167410f7fd16c72ccd6270551405f2a

Fix naming and function argument parsing sytle

build_tools/cmake/iree_macros.cmake

diff --git a/build_tools/cmake/iree_macros.cmake b/build_tools/cmake/iree_macros.cmake
index dddbc6c..64f1201 100644
--- a/build_tools/cmake/iree_macros.cmake
+++ b/build_tools/cmake/iree_macros.cmake
@@ -31,11 +31,11 @@
 # iree_to_bool
 #
 # Sets `variable` to `ON` if `value` is true and `OFF` otherwise.
-function(iree_to_bool variable value)
-  if(value)
-    set(${variable} "ON" PARENT_SCOPE)
+function(iree_to_bool VARIABLE VALUE)
+  if(VALUE)
+    set(${VARIABLE} "ON" PARENT_SCOPE)
   else()
-    set(${variable} "OFF" PARENT_SCOPE)
+    set(${VARIABLE} "OFF" PARENT_SCOPE)
   endif()
 endfunction()
 
@@ -215,12 +215,12 @@
 # only be built on host.
 #
 # Parameters:
-# - target: the target to take on dependencies
-# - dependency: additional dependencies to append to target
-function(iree_add_executable_dependencies target dependency)
+# TARGET: the target to take on dependencies
+# DEPENDENCY: additional dependencies to append to target
+function(iree_add_executable_dependencies TARGET DEPENDENCY)
   if(CMAKE_CROSSCOMPILING)
-    add_dependencies(${target} iree_host_${dependency})
+    add_dependencies(${TARGET} iree_host_${DEPENDENCY})
   else()
-    add_dependencies(${target} ${dependency})
+    add_dependencies(${TARGET} ${DEPENDENCY})
   endif()
 endfunction()