commit c5bc37f47eacc5b73ea8dda846056553e18bed68
author Kunwar Grover <groverkss@gmail.com> Fri Jan 17 18:29:29 2025 +0000
committer GitHub <noreply@github.com> Fri Jan 17 18:29:29 2025 +0000
tree c21df9770d8307843f12745387231b20b3f9fd53
parent e1f010c4e3bdaba2695064b599d15e39d70d5d76

[Util] Fix OptimizeIntArithmetic pattern failure condition (#19731)

The condition is wrong and leads to infinite loops if the input is i32
and output is index type.

compiler/src/iree/compiler/Dialect/Util/Transforms/OptimizeIntArithmetic.cpp

diff --git a/compiler/src/iree/compiler/Dialect/Util/Transforms/OptimizeIntArithmetic.cpp b/compiler/src/iree/compiler/Dialect/Util/Transforms/OptimizeIntArithmetic.cpp
index fdee32e..9b17288 100644
--- a/compiler/src/iree/compiler/Dialect/Util/Transforms/OptimizeIntArithmetic.cpp
+++ b/compiler/src/iree/compiler/Dialect/Util/Transforms/OptimizeIntArithmetic.cpp
@@ -135,7 +135,7 @@
                                 PatternRewriter &rewriter) const override {
     Type inType = origIndexOp.getIn().getType();
     Type outType = origIndexOp.getOut().getType();
-    if (!inType.isSignlessInteger(64) && isa<IndexType>(outType))
+    if (!inType.isSignlessInteger(64) || !isa<IndexType>(outType))
       return failure();
 
     Operation *producer = origIndexOp.getIn().getDefiningOp();