Deflake LoopTest.WaitAnyBlocking and WaitAllBlocking. (#17863)
Missed these in https://github.com/iree-org/iree/pull/17857 since I only
saw `WaitOneBlocking` flake on CI. The other test cases can flake too.
diff --git a/runtime/src/iree/base/loop_test.h b/runtime/src/iree/base/loop_test.h
index 1386b3d..ae1ad1b 100644
--- a/runtime/src/iree/base/loop_test.h
+++ b/runtime/src/iree/base/loop_test.h
@@ -596,6 +596,11 @@
// Spin up the thread to signal the event after a short delay.
// We need to do this before we issue the wait so that loops which perform the
// wait inline can still make forward progress even if they block.
+ //
+ // Note: there is a race here that can cause flakes. If this new thread
+ // starts running after the iree_loop_wait_* timeout below, the status check
+ // will fail. We make the timeout there sufficiently long to give the OS
+ // enough time to switch threads a few times.
std::thread thread([&]() {
IREE_TRACE_SCOPE();
std::this_thread::sleep_for(std::chrono::milliseconds(50));
@@ -768,6 +773,11 @@
// Spin up the thread to signal the event after a short delay.
// We need to do this before we issue the wait so that loops which perform the
// wait inline can still make forward progress even if they block.
+ //
+ // Note: there is a race here that can cause flakes. If this new thread
+ // starts running after the iree_loop_wait_* timeout below, the status check
+ // will fail. We make the timeout there sufficiently long to give the OS
+ // enough time to switch threads a few times.
std::thread thread([&]() {
IREE_TRACE_SCOPE();
std::this_thread::sleep_for(std::chrono::milliseconds(50));
@@ -783,7 +793,7 @@
} user_data;
IREE_ASSERT_OK(iree_loop_wait_any(
loop, IREE_ARRAYSIZE(wait_sources), wait_sources,
- iree_make_timeout_ms(200),
+ iree_make_timeout_ms(2000),
+[](void* user_data_ptr, iree_loop_t loop, iree_status_t status) {
IREE_TRACE_SCOPE();
IREE_EXPECT_OK(status);
@@ -941,6 +951,11 @@
// Spin up the thread to signal the event after a short delay.
// We need to do this before we issue the wait so that loops which perform the
// wait inline can still make forward progress even if they block.
+ //
+ // Note: there is a race here that can cause flakes. If this new thread
+ // starts running after the iree_loop_wait_* timeout below, the status check
+ // will fail. We make the timeout there sufficiently long to give the OS
+ // enough time to switch threads a few times.
std::thread thread([&]() {
IREE_TRACE_SCOPE();
std::this_thread::sleep_for(std::chrono::milliseconds(50));
@@ -956,7 +971,7 @@
} user_data;
IREE_ASSERT_OK(iree_loop_wait_all(
loop, IREE_ARRAYSIZE(wait_sources), wait_sources,
- iree_make_timeout_ms(200),
+ iree_make_timeout_ms(2000),
+[](void* user_data_ptr, iree_loop_t loop, iree_status_t status) {
IREE_TRACE_SCOPE();
IREE_EXPECT_OK(status);
