Bazel to CMake: Mark linkopts unimplemented
These are not handled by the script, but should also be used in CMake.
Another option would be to error if there are any unrecognized kwargs and then handle all kwargs that we care about or are no-ops in CMake. The tradeoffs would depend on how many possible kwargs there are, how many we actually use, and how many are no-ops in CMake. Deferring that investigation. Even if we do this, we should probably accept the kwargs and then check their contents is empty so that we can choose whether to continue with a comment or error out depending on strict mode.
PiperOrigin-RevId: 298401856
diff --git a/build_tools/bazel_to_cmake/bazel_to_cmake.py b/build_tools/bazel_to_cmake/bazel_to_cmake.py
index 78b2229..30cadad 100755
--- a/build_tools/bazel_to_cmake/bazel_to_cmake.py
+++ b/build_tools/bazel_to_cmake/bazel_to_cmake.py
@@ -377,7 +377,10 @@
deps=None,
alwayslink=False,
testonly=False,
+ linkopts=None,
**kwargs):
+ if linkopts:
+ self._convert_unimplemented_function("linkopts")
name_block = self._convert_name_block(name)
hdrs_block = self._convert_hdrs_block(hdrs)
textual_hdrs_block = self._convert_textual_hdrs_block(textual_hdrs)
@@ -412,7 +415,9 @@
"deps_block": deps_block,
}
- def cc_binary(self, name, srcs=None, deps=None, **kwargs):
+ def cc_binary(self, name, srcs=None, deps=None, linkopts=None, **kwargs):
+ if linkopts:
+ self._convert_unimplemented_function("linkopts")
name_block = self._convert_name_block(name)
out_block = self._convert_out_block(name)
srcs_block = self._convert_srcs_block(srcs)
