)]}' { "commit": "a3e97f1f74e51524fbd2f2fc27579b8bf15e68f2", "tree": "f8dacac9910ba8b816738e6e65070cfc7f7738bb", "parents": [ "e5faf044ae469a6f15114c54aec05bfebcf9127b" ], "author": { "name": "Stella Laurenzo", "email": "stellaraccident@gmail.com", "time": "Sat Dec 05 23:29:13 2020 -0800" }, "committer": { "name": "Stella Laurenzo", "email": "stellaraccident@gmail.com", "time": "Mon Dec 07 15:10:32 2020 -0800" }, "message": "Step 4/n: Integrate TensorFlow compiler build and tests into CMake.\n\n* New option: \u0027IREE_BUILD_TENSORFLOW_COMPILER\u0027\n* Adds some cmake hackery to find and configure bazel, scoping it under the build directory.\n* Adds an iree_add_bazel_invocation() function that executes bazel and creates cmake targets for some built executables.\n* Adds the cmake target \u0027integrations_iree_tensorflow_importers\u0027 as a bazel invocation.\n* Wires up the build for pyiree.tools.tf to link the binary from the bazel side. The result is a built bindings/python directory that can be used for tests and such with no further build required (or deployed directly).\n* Once I\u0027m done with this transition, we can completely remove all of the python building from bazel, likely just replacing tests with a shell script runner, since they can just run standalone.\n* Also had to fix some issues with the python config (it wasn\u0027t detecting virtual envs properly due to using the old FindPython vars).\n* Added yet another hack to run_lit.sh because with bazel\u0027s out directory living in the build directory, it was taking 2m+ to scan files for things to add to the path. We shouldn\u0027t have been doing that, but also... Bazel, WTF?\n* Note that old build/tests of the integrations directory were double building almost everything because Bazel was differentiating between objects bound for binaries and for shared libraries. In addition, since it included the complete IREE compiler, it was building all of LLVM.\n* In the new world, we only build one static binary, and since it is just the frontend, the amount of things it needs to compile from LLVM are minimal. Most of the time is in compiling eigen kernels.\n* This will probably take some tweaking before it is ready for prime time.\n\nStats:\n\nClean build:\n configure: ~1m\n ninja build: ~10m (includes TF)\n ctest -E \u0027vulkan|benchmark\u0027: 14s (includes new TF tests but not the whole e2e directory yet)\n\nOn a rebuild with CCache and Bazel\u0027s disk cache enabled from the above, a rebuild of everything took 18s.\n", "tree_diff": [ { "type": "modify", "old_id": "b37f0e076d0956dfe96dce520db1f30c4680bd95", "old_mode": 33188, "old_path": "CMakeLists.txt", "new_id": "9f0872049fdc837096fb0cd467333d5a4d901e7e", "new_mode": 33188, "new_path": "CMakeLists.txt" }, { "type": "modify", "old_id": "5d92550391e9b72f584e1048e88ecc26ba2711cd", "old_mode": 33188, "old_path": "bindings/python/pyiree/compiler2/tf.py", "new_id": "17d098e066b9acece1bb7aa3203a45e89c8f0760", "new_mode": 33188, "new_path": "bindings/python/pyiree/compiler2/tf.py" }, { "type": "modify", "old_id": "94027d357b02448ce3063c20022bef01acd5f72f", "old_mode": 33188, "old_path": "bindings/python/pyiree/tools/core/CMakeLists.txt", "new_id": "9e4364cf7574e3474969a4fa96270738db41cbfb", "new_mode": 33188, "new_path": "bindings/python/pyiree/tools/core/CMakeLists.txt" }, { "type": "modify", "old_id": "e70629ade254721a8a62d52426a01b21cf57ee12", "old_mode": 33188, "old_path": "bindings/python/tests/CMakeLists.txt", "new_id": "701bb728ebb09424cbfd45997a3474dd53713bf2", "new_mode": 33188, "new_path": "bindings/python/tests/CMakeLists.txt" }, { "type": "modify", "old_id": "ec5111be77a0c828b920e73cd5f811fb6f1c8a2b", "old_mode": 33188, "old_path": "bindings/python/tests/compiler_tf_test.py", "new_id": "41fc94e861da71d3624070d2ee1b85c8faf17b0c", "new_mode": 33188, "new_path": "bindings/python/tests/compiler_tf_test.py" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "2d2bfb2575fa23bf8b33fcbd875ad3ae1fda0774", "new_mode": 33188, "new_path": "build_tools/cmake/bazel.bat.in" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "65385e296b8b65e9a7a67cfcb6a6fb3e54edf2ba", "new_mode": 33188, "new_path": "build_tools/cmake/bazel.sh.in" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "528d2447ee6c787240aaea1709f12deaf1ce76a8", "new_mode": 33188, "new_path": "build_tools/cmake/configure_bazel.cmake" }, { "type": "modify", "old_id": "f749f90cf5cb81f19e5d49a890bf8233c2141347", "old_mode": 33188, "old_path": "build_tools/cmake/iree_cross_compile.cmake", "new_id": "4433efff39f256704b8f322b1b1c136752308c25", "new_mode": 33188, "new_path": "build_tools/cmake/iree_cross_compile.cmake" }, { "type": "modify", "old_id": "04466b5a90b0bc058910e1ea9c1a75586aa11656", "old_mode": 33188, "old_path": "build_tools/cmake/iree_macros.cmake", "new_id": "8f4e5d2539e601a8a8f161fb65f4ca7fd04e6a13", "new_mode": 33188, "new_path": "build_tools/cmake/iree_macros.cmake" }, { "type": "modify", "old_id": "13510d476a94c3af2e693cf00c13ddbb30f5d3fc", "old_mode": 33188, "old_path": "build_tools/cmake/iree_multipy.cmake", "new_id": "3456fad15d2e184bdf80f587494b63cbdfde08f4", "new_mode": 33188, "new_path": "build_tools/cmake/iree_multipy.cmake" }, { "type": "modify", "old_id": "f0bac9321f95a69a5132c1ea939d99bff1ff7941", "old_mode": 33188, "old_path": "configure_bazel.py", "new_id": "18be4a468e4713b4bb12cd0207ab4aa2eeaaa06f", "new_mode": 33188, "new_path": "configure_bazel.py" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "6194ee371f7c199e94e352a32c834b0b6838fcb2", "new_mode": 33188, "new_path": "integrations/tensorflow/CMakeLists.txt" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "31b61a29fb06d2baa5ec7fa296fc3cdd5438d75c", "new_mode": 33188, "new_path": "integrations/tensorflow/bindings/python/CMakeLists.txt" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "e69de29bb2d1d6434b8b29ae775ad8c2e48c5391", "new_mode": 33188, "new_path": "integrations/tensorflow/bindings/python/pyiree/tools/tf/.skip_bazel_to_cmake" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "a10869b41298c841c3b4b26e891e78bf3b201052", "new_mode": 33188, "new_path": "integrations/tensorflow/bindings/python/pyiree/tools/tf/CMakeLists.txt" }, { "type": "rename", "old_id": "ceb37eade17a2234e06a15963ae7799d40283b9b", "old_mode": 33188, "old_path": "bindings/python/pyiree/tools/tf/__init__.py", "new_id": "ceb37eade17a2234e06a15963ae7799d40283b9b", "new_mode": 33188, "new_path": "integrations/tensorflow/bindings/python/pyiree/tools/tf/__init__.py", "score": 100 }, { "type": "modify", "old_id": "704c7ccc5db9f7b0c3549a22fc80a7ee2585ad0e", "old_mode": 33261, "old_path": "iree/tools/run_lit.sh", "new_id": "78cbf66d0cd42b0591c8a8d461bb07f194b62df1", "new_mode": 33261, "new_path": "iree/tools/run_lit.sh" } ] }