)]}'
{
  "commit": "a33484ef95581068c7d06c18279dcf8a389f889a",
  "tree": "299340831661d7f1cf8ac3243666584e25de897c",
  "parents": [
    "78aff2f6bb768f60a4b468abf6737e11a10d4406"
  ],
  "author": {
    "name": "Eylon Eliyahu Krause",
    "email": "64223519+EylonKrause@users.noreply.github.com",
    "time": "Mon Jul 06 15:04:03 2026 +0300"
  },
  "committer": {
    "name": "GitHub",
    "email": "noreply@github.com",
    "time": "Mon Jul 06 14:04:03 2026 +0200"
  },
  "message": "[Runtime] Honor the base argument in atoi_int32_base (#24677)\n\n### Problem\n`iree_string_view_atoi_int32_base` ignores its `base` argument.\n\n### Root cause\n`runtime/src/iree/base/string_view.c:387` calls `strtol(temp, \u0026end, 0)`\n— the `base` parameter is never used, so any requested radix is silently\ndiscarded and the string is parsed with C auto-detection (leading `0x` →\nhex, leading `0` → octal, else decimal). The three sibling `_base`\nfunctions forward the argument correctly: `strtoul(temp, \u0026end, base)`\n(uint32, :413), `strtoll(..., base)` (int64, :436), `strtoull(...,\nbase)` (uint64, :462). The non-`base` wrapper\n`iree_string_view_atoi_int32` already passes `0` explicitly (:399), so\nthe `_base` variant is clearly meant to honor a caller-supplied radix. A\ncaller requesting base 16 or 2 gets wrong values (e.g. base\u003d16 `\"10\"` →\n10 instead of 16).\n\n### Fix\nForward `base` to `strtol`, matching the sibling `_base` functions.\n\n### Verification\nStatic reasoning + sibling consistency; trivially checkable:\n`strtol(\"10\", \u0026e, 16) \u003d\u003d 16` vs the current `strtol(\"10\", \u0026e, 0) \u003d\u003d 10`.\n(No full runtime build on my machine — happy to add a unit test if\nuseful.)\n\nSigned-off-by: Eylon Krause \u003ceylon1909@gmail.com\u003e",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "a8e8064ca2246b7fe08c26f56f75c1f31e9fed35",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/base/string_view.c",
      "new_id": "a01527f52465e2797d1a72e41b7d8fe591ecd982",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/base/string_view.c"
    },
    {
      "type": "modify",
      "old_id": "cb1eb2e59cb8fe47fe494d5ce54cae330fcee165",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/base/string_view_test.cc",
      "new_id": "c4f40b7f4bafb2fd95df724092241b2037dbfa09",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/base/string_view_test.cc"
    }
  ]
}
