Use a symlink instead of a copy for run_binary_test (#3541)
This avoids a bash requirement and an unnecessary copy. I'm not sure
why I originally thought a copy was necessary, but builds seem to pass.
Also changed the attr options to specify that `test_binary` should be
executable.
diff --git a/build_tools/bazel/run_binary_test.bzl b/build_tools/bazel/run_binary_test.bzl
index 79536f3..aa165ea 100644
--- a/build_tools/bazel/run_binary_test.bzl
+++ b/build_tools/bazel/run_binary_test.bzl
@@ -32,12 +32,10 @@
"""
def _run_binary_test_impl(ctx):
- ctx.actions.run_shell(
- inputs = [ctx.file.test_binary],
- outputs = [ctx.outputs.executable],
- command = "cp $1 $2",
- arguments = [ctx.file.test_binary.path, ctx.outputs.executable.path],
- mnemonic = "CopyExecutable",
+ ctx.actions.symlink(
+ target_file = ctx.executable.test_binary,
+ output = ctx.outputs.executable,
+ is_executable = True,
)
data_runfiles = ctx.runfiles(files = ctx.files.data)
@@ -54,7 +52,8 @@
attrs = {
"test_binary": attr.label(
mandatory = True,
- allow_single_file = True,
+ executable = True,
+ cfg = "target",
),
"data": attr.label_list(allow_empty = True, allow_files = True),
},
