Switch Softmax and LogSoftmax ops to be expansions instead of TF->HLO legalizations.
* The impetus for this was to enable a more effective dynamic shapes representation (staying high level vs doing manual shape massaging it better for code generation).
* The generated HLO is equivalent in the static shapes case.
* Side effect of making Softmax unranked compatible at the TF conversion level.
* The lower_tf.mlir test case was not actually piping to FileCheck. This has been fixed and a lot of unrelated test fixes are included (since this file had never effectively been tested).
* The tensorflow/transforms directory is pretty tortured. It feels like it should actually be half a dozen different directories. I found that there was no place to have not statically registered test passes, and tf_test_passes.td was namespaced/configured wrong for anything but saved model tests. I think I improved it and at least carved out a place for people to easily add more test passes (otherwise, no one will do proper unit testing -- which seems to be the situation that is prevalent). It's not great. This directory needs triage. Considering that the tests weren't even running before, I consider how I have it to be a minor improvement.
PiperOrigin-RevId: 381153956
diff --git a/integrations/tensorflow/iree_tf_compiler/TF/ConvertToMHLO.cpp b/integrations/tensorflow/iree_tf_compiler/TF/ConvertToMHLO.cpp
index 717dd29..1e03d63 100644
--- a/integrations/tensorflow/iree_tf_compiler/TF/ConvertToMHLO.cpp
+++ b/integrations/tensorflow/iree_tf_compiler/TF/ConvertToMHLO.cpp
@@ -53,7 +53,7 @@
// Lower TF Patterns must be separate from canonocalization patterns as
// they are sometimes inversions of eachother.
OwningRewritePatternList lowerTfPatterns(&getContext());
- mlir::TF::PopulateLoweringTFPatterns(context, &lowerTfPatterns);
+ mlir::TF::PopulateTFLoweringBeforeHLOPatterns(context, &lowerTfPatterns);
OwningRewritePatternList canonicalizePatterns(&getContext());
for (auto *op : context->getRegisteredOperations()) {
