)]}'
{
  "commit": "981f48768a5a27baac818b8afa506abaf4ba75ad",
  "tree": "1274fba61e97d21e304fe1903fc98eda2eea969d",
  "parents": [
    "b00b12fb6bdd301a85c15f084fccdfd275e0b64a"
  ],
  "author": {
    "name": "Scott Todd",
    "email": "scotttodd@google.com",
    "time": "Wed Nov 03 08:30:15 2021 -0700"
  },
  "committer": {
    "name": "GitHub",
    "email": "noreply@github.com",
    "time": "Wed Nov 03 08:30:15 2021 -0700"
  },
  "message": "Flip -iree-llvm-link-embedded to true by default. (#7372)\n\nTying up loose ends on https://github.com/google/iree/issues/4717.\r\n\r\nThe system linking path is more flexible for debugging and integration with platform-specific tooling, while the embedded linking path is more portable and is likely to have better performance.\r\n\r\nSummary of changes:\r\n\r\n* Remove explicit `--iree-llvm-link-embedded\u003dtrue` from targets using `dylib-sync`\r\n* Remove test suites that were testing the embedded path explicitly (now duplicates of the default test suites)\r\n* Disambiguate `iree-llvm-system-linker-path`/`IREE_LLVMAOT_SYSTEM_LINKER_PATH` and `iree-llvm-embedded-linker-path`/`IREE_LLVMAOT_EMBEDDED_LINKER_PATH` flags/env-vars\r\n  * Also remove docs referencing them. If the automatic discovery fails, error messages should give enough context for developers to debug on their own.\r\n* Include source build of `lld` in test targets that now depend on it\r\n* Smooth out linker tool discovery in `EmbeddedLinkerTool.cpp`",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "e63ba225c123ebc4c855adcaff4c280d4a189350",
      "old_mode": 33188,
      "old_path": "benchmarks/TFLite/CMakeLists.txt",
      "new_id": "358f117a23e33abd62fd1412048ba9c664a31d8d",
      "new_mode": 33188,
      "new_path": "benchmarks/TFLite/CMakeLists.txt"
    },
    {
      "type": "modify",
      "old_id": "5076e16aa94aa65b36d260bb354006fbd09b7a53",
      "old_mode": 33188,
      "old_path": "benchmarks/TensorFlow/CMakeLists.txt",
      "new_id": "11ce458297f4886206db51680fbb4f9a7755f117",
      "new_mode": 33188,
      "new_path": "benchmarks/TensorFlow/CMakeLists.txt"
    },
    {
      "type": "modify",
      "old_id": "0147c6c3d58e3bdffa464cf24af4a09d09c10490",
      "old_mode": 33261,
      "old_path": "build_tools/bazel/build_core.sh",
      "new_id": "98fab39249987d8a281174ea9ba0b594537ae1f7",
      "new_mode": 33261,
      "new_path": "build_tools/bazel/build_core.sh"
    },
    {
      "type": "modify",
      "old_id": "bbfc8e3e2ff7e399d32fcba271a9467b78173ccc",
      "old_mode": 33188,
      "old_path": "build_tools/bazel_to_cmake/bazel_to_cmake_targets.py",
      "new_id": "f5bc2e83f89b01b29d0f624eb341f3ce29bad316",
      "new_mode": 33188,
      "new_path": "build_tools/bazel_to_cmake/bazel_to_cmake_targets.py"
    },
    {
      "type": "modify",
      "old_id": "29259547592d399124d3befc07efc5188209e863",
      "old_mode": 33261,
      "old_path": "build_tools/kokoro/gcp_ubuntu/cmake/linux/riscv64/test.sh",
      "new_id": "f24a75ddc7968cab19d03c325977ad24a02c3312",
      "new_mode": 33261,
      "new_path": "build_tools/kokoro/gcp_ubuntu/cmake/linux/riscv64/test.sh"
    },
    {
      "type": "modify",
      "old_id": "c5c7ee05f7a49fa3b1de5a6d21ed323f3a37a9df",
      "old_mode": 33188,
      "old_path": "docs/developers/get_started/getting_started_android_cmake.md",
      "new_id": "df64baa4101fd406a222075cd204a8cd53fa0671",
      "new_mode": 33188,
      "new_path": "docs/developers/get_started/getting_started_android_cmake.md"
    },
    {
      "type": "modify",
      "old_id": "7010b1e667e5ad4ea0d741db007706eeb3844f96",
      "old_mode": 33188,
      "old_path": "docs/developers/get_started/getting_started_linux_cmake.md",
      "new_id": "0c780300eb9fada1c6880d1044a9b17e8b28577c",
      "new_mode": 33188,
      "new_path": "docs/developers/get_started/getting_started_linux_cmake.md"
    },
    {
      "type": "modify",
      "old_id": "84e6c235e5073315c4ce04c2800671e1da589fd3",
      "old_mode": 33188,
      "old_path": "docs/developers/get_started/getting_started_riscv_cmake.md",
      "new_id": "e863d3d3f4622b906f3681e7ecff3c55d9063157",
      "new_mode": 33188,
      "new_path": "docs/developers/get_started/getting_started_riscv_cmake.md"
    },
    {
      "type": "modify",
      "old_id": "e4054561b164c4be9ca3224e7657e4afae8f4242",
      "old_mode": 33188,
      "old_path": "docs/developers/get_started/getting_started_windows_cmake.md",
      "new_id": "bd02798c5b140adcf41daf228c4b521812224257",
      "new_mode": 33188,
      "new_path": "docs/developers/get_started/getting_started_windows_cmake.md"
    },
    {
      "type": "modify",
      "old_id": "093480781957bfa308c645c249ca58db5b50d0c7",
      "old_mode": 33188,
      "old_path": "docs/website/docs/deployment-configurations/bare-metal.md",
      "new_id": "498e8baa9bf8bc626f33781038273ee599e72862",
      "new_mode": 33188,
      "new_path": "docs/website/docs/deployment-configurations/bare-metal.md"
    },
    {
      "type": "modify",
      "old_id": "25abad6008475fa02c103f33aabac13691667586",
      "old_mode": 33188,
      "old_path": "iree/compiler/Dialect/HAL/Target/LLVM/LLVMAOTTarget.cpp",
      "new_id": "ed514fe66d0bfb9fcd20a5c2d6d1a847f31abc4f",
      "new_mode": 33188,
      "new_path": "iree/compiler/Dialect/HAL/Target/LLVM/LLVMAOTTarget.cpp"
    },
    {
      "type": "modify",
      "old_id": "e027925a770947b9c19ed675c77c5729de9d2393",
      "old_mode": 33188,
      "old_path": "iree/compiler/Dialect/HAL/Target/LLVM/LLVMTargetOptions.cpp",
      "new_id": "768fb80fad9fed24cd5d9967226ff58b19fb7fb4",
      "new_mode": 33188,
      "new_path": "iree/compiler/Dialect/HAL/Target/LLVM/LLVMTargetOptions.cpp"
    },
    {
      "type": "modify",
      "old_id": "0a0124f90b001f82209b425d5420fa0c643337d9",
      "old_mode": 33188,
      "old_path": "iree/compiler/Dialect/HAL/Target/LLVM/LLVMTargetOptions.h",
      "new_id": "f1e9fe5db88376d1780dd7954668d227d5f86672",
      "new_mode": 33188,
      "new_path": "iree/compiler/Dialect/HAL/Target/LLVM/LLVMTargetOptions.h"
    },
    {
      "type": "modify",
      "old_id": "aede2a6aea1b343d79cd4dc27d062146a90d5213",
      "old_mode": 33188,
      "old_path": "iree/compiler/Dialect/HAL/Target/LLVM/LinkerTool.cpp",
      "new_id": "d42d5396fa08112b8786c282ce19c2156fc11b94",
      "new_mode": 33188,
      "new_path": "iree/compiler/Dialect/HAL/Target/LLVM/LinkerTool.cpp"
    },
    {
      "type": "modify",
      "old_id": "7039c141d0eb0db55534fecc031a31ac7ecb5c6e",
      "old_mode": 33188,
      "old_path": "iree/compiler/Dialect/HAL/Target/LLVM/LinkerTool.h",
      "new_id": "2fb402fbccd36e5452d33847b4af0a7665232e97",
      "new_mode": 33188,
      "new_path": "iree/compiler/Dialect/HAL/Target/LLVM/LinkerTool.h"
    },
    {
      "type": "modify",
      "old_id": "60ed5cee8598c705f891e0e892032412f077bbfa",
      "old_mode": 33188,
      "old_path": "iree/compiler/Dialect/HAL/Target/LLVM/internal/AndroidLinkerTool.cpp",
      "new_id": "f07e93021c18ba2d02ba2d20dda04a5d97764ad0",
      "new_mode": 33188,
      "new_path": "iree/compiler/Dialect/HAL/Target/LLVM/internal/AndroidLinkerTool.cpp"
    },
    {
      "type": "modify",
      "old_id": "cda219ea5e08bb478717581fad8c0e6d313a6ad3",
      "old_mode": 33188,
      "old_path": "iree/compiler/Dialect/HAL/Target/LLVM/internal/EmbeddedLinkerTool.cpp",
      "new_id": "315ce3cc097b0ad5ab4658249b76ba9b3789c551",
      "new_mode": 33188,
      "new_path": "iree/compiler/Dialect/HAL/Target/LLVM/internal/EmbeddedLinkerTool.cpp"
    },
    {
      "type": "modify",
      "old_id": "b54a98e0f8daef6b4974609d1353591b0bc4170e",
      "old_mode": 33188,
      "old_path": "iree/compiler/Dialect/HAL/Target/LLVM/internal/RiscvLinkerTool.cpp",
      "new_id": "1cbb730a239e006cc45472a2757650d28ca2eb7b",
      "new_mode": 33188,
      "new_path": "iree/compiler/Dialect/HAL/Target/LLVM/internal/RiscvLinkerTool.cpp"
    },
    {
      "type": "modify",
      "old_id": "cdc1b2111cbf93c867cf73908c0bf2cc7df72252",
      "old_mode": 33188,
      "old_path": "iree/compiler/Dialect/HAL/Target/LLVM/internal/UnixLinkerTool.cpp",
      "new_id": "375ffbd66fbccbbc0218f896cb79ba19b4e46a65",
      "new_mode": 33188,
      "new_path": "iree/compiler/Dialect/HAL/Target/LLVM/internal/UnixLinkerTool.cpp"
    },
    {
      "type": "modify",
      "old_id": "fa92479b4e63accffa58e25cbe8bd941e91f1096",
      "old_mode": 33188,
      "old_path": "iree/compiler/Dialect/HAL/Target/LLVM/internal/WasmLinkerTool.cpp",
      "new_id": "2e5eab1b0dc40ed3e8348e41c6b4af10b409950b",
      "new_mode": 33188,
      "new_path": "iree/compiler/Dialect/HAL/Target/LLVM/internal/WasmLinkerTool.cpp"
    },
    {
      "type": "modify",
      "old_id": "8405a049c67a1f3e68921c51f1dedae4eae40966",
      "old_mode": 33188,
      "old_path": "iree/compiler/Dialect/HAL/Target/LLVM/internal/WindowsLinkerTool.cpp",
      "new_id": "41e28948a6687d8bb684e9a367b4e357e6761aee",
      "new_mode": 33188,
      "new_path": "iree/compiler/Dialect/HAL/Target/LLVM/internal/WindowsLinkerTool.cpp"
    },
    {
      "type": "modify",
      "old_id": "5a93026c934ee2ff0205ef2bf6cf7da874137e05",
      "old_mode": 33188,
      "old_path": "iree/compiler/Dialect/HAL/Target/LLVM/test/BUILD",
      "new_id": "1a77b77554f3c0d3f73f9817622c68cba9fe6e18",
      "new_mode": 33188,
      "new_path": "iree/compiler/Dialect/HAL/Target/LLVM/test/BUILD"
    },
    {
      "type": "modify",
      "old_id": "21398e9633519dc4eef029151d33acac22ea083d",
      "old_mode": 33188,
      "old_path": "iree/compiler/Dialect/HAL/Target/LLVM/test/CMakeLists.txt",
      "new_id": "9120ed774ef16687156655bac9c7de12ac4c2c3c",
      "new_mode": 33188,
      "new_path": "iree/compiler/Dialect/HAL/Target/LLVM/test/CMakeLists.txt"
    },
    {
      "type": "modify",
      "old_id": "10b74e4ba0d974e96c67dfb93d8168adc340f2e5",
      "old_mode": 33188,
      "old_path": "iree/compiler/Dialect/HAL/Target/LLVM/test/smoketest.mlir",
      "new_id": "91a4ff5b27004862786493f097ded23d1e280907",
      "new_mode": 33188,
      "new_path": "iree/compiler/Dialect/HAL/Target/LLVM/test/smoketest.mlir"
    },
    {
      "type": "modify",
      "old_id": "7ccee79d7f0716d413877369df6f08e2e59220b2",
      "old_mode": 33188,
      "old_path": "iree/hal/local/elf/testdata/generate.sh",
      "new_id": "078b2fbbeb98961b4f921683ffe15ae0a50c5079",
      "new_mode": 33188,
      "new_path": "iree/hal/local/elf/testdata/generate.sh"
    },
    {
      "type": "modify",
      "old_id": "3ba507da00f5451bb898642de7e3b05236eb52e9",
      "old_mode": 33188,
      "old_path": "iree/hal/local/executable_library_benchmark.md",
      "new_id": "77b32f55ca0bb624d23b2fd214d166a6b7b2d6d0",
      "new_mode": 33188,
      "new_path": "iree/hal/local/executable_library_benchmark.md"
    },
    {
      "type": "modify",
      "old_id": "968870241403b27078b55312159e5809779b77e4",
      "old_mode": 33188,
      "old_path": "iree/samples/simple_embedding/BUILD",
      "new_id": "43d61257192a4477f4f77a827b89119afab0d50a",
      "new_mode": 33188,
      "new_path": "iree/samples/simple_embedding/BUILD"
    },
    {
      "type": "modify",
      "old_id": "670169be00493a76809fc07b74407c64ecd7897b",
      "old_mode": 33188,
      "old_path": "iree/samples/simple_embedding/CMakeLists.txt",
      "new_id": "dedb908ff0be6ade1c5f78e06a1bd1ff857076a8",
      "new_mode": 33188,
      "new_path": "iree/samples/simple_embedding/CMakeLists.txt"
    },
    {
      "type": "modify",
      "old_id": "3b9f54e2e9a90024d0636bd980efd3a2f08c22fe",
      "old_mode": 33188,
      "old_path": "iree/samples/static_library/CMakeLists.txt",
      "new_id": "3c9a4a28fb42dfd8030bc736c880d4afbae3417a",
      "new_mode": 33188,
      "new_path": "iree/samples/static_library/CMakeLists.txt"
    },
    {
      "type": "modify",
      "old_id": "9752101ade3ff6d878635931afe03c2780bf9a07",
      "old_mode": 33188,
      "old_path": "iree/test/e2e/linalg_ext_ops/BUILD",
      "new_id": "fc0b0e60f231dbc3e174dbcdf1dfdbce2fcb9163",
      "new_mode": 33188,
      "new_path": "iree/test/e2e/linalg_ext_ops/BUILD"
    },
    {
      "type": "modify",
      "old_id": "78b49f431a98f51a47e56827185d6f1ca4d24a88",
      "old_mode": 33188,
      "old_path": "iree/test/e2e/linalg_ext_ops/CMakeLists.txt",
      "new_id": "7d46dba223696936db475e48597a11601b7f8017",
      "new_mode": 33188,
      "new_path": "iree/test/e2e/linalg_ext_ops/CMakeLists.txt"
    },
    {
      "type": "modify",
      "old_id": "be8a4536850df312eacca42b4af76bd278c4a75b",
      "old_mode": 33188,
      "old_path": "iree/test/e2e/models/BUILD",
      "new_id": "9d140ec5ba405ad70e9308d574d8bf451ae07e3d",
      "new_mode": 33188,
      "new_path": "iree/test/e2e/models/BUILD"
    },
    {
      "type": "modify",
      "old_id": "5cef709f3801817c6c4cefb72f000c7e08bab0a5",
      "old_mode": 33188,
      "old_path": "iree/test/e2e/models/CMakeLists.txt",
      "new_id": "ad94da25435c4ae19e664b2666942d71e6087031",
      "new_mode": 33188,
      "new_path": "iree/test/e2e/models/CMakeLists.txt"
    },
    {
      "type": "modify",
      "old_id": "4b2a1ce5096f6914c703d7b7cfd5e5b73b519e04",
      "old_mode": 33188,
      "old_path": "iree/test/e2e/tensor_ops/BUILD",
      "new_id": "2fd0fcf369821c841c6d7c71fa5cf9a648f426b1",
      "new_mode": 33188,
      "new_path": "iree/test/e2e/tensor_ops/BUILD"
    },
    {
      "type": "modify",
      "old_id": "325e8592f63cb1aeadb44d8a1491a188359695ba",
      "old_mode": 33188,
      "old_path": "iree/test/e2e/tensor_ops/CMakeLists.txt",
      "new_id": "4eceb384c850171497854698f3f5da8302465eb4",
      "new_mode": 33188,
      "new_path": "iree/test/e2e/tensor_ops/CMakeLists.txt"
    },
    {
      "type": "modify",
      "old_id": "3cf26c8f453aaf96419707d07e67e9dadac307ca",
      "old_mode": 33188,
      "old_path": "iree/test/e2e/xla_ops/BUILD",
      "new_id": "b43fb72d2d9ebebe3c40d6fde1b918432aa652a7",
      "new_mode": 33188,
      "new_path": "iree/test/e2e/xla_ops/BUILD"
    },
    {
      "type": "modify",
      "old_id": "cc22a75c9cf849ff7c659ae363b3fb4dff3111db",
      "old_mode": 33188,
      "old_path": "iree/test/e2e/xla_ops/CMakeLists.txt",
      "new_id": "ab355a61c3e28b0b5f2eeb6393b1426ab205b370",
      "new_mode": 33188,
      "new_path": "iree/test/e2e/xla_ops/CMakeLists.txt"
    },
    {
      "type": "modify",
      "old_id": "41489e0a962c293d6faa14b097deb33bad555699",
      "old_mode": 33188,
      "old_path": "iree/tools/test/BUILD",
      "new_id": "2c1088318abd88489e2ed922ebdb81404b8c49ae",
      "new_mode": 33188,
      "new_path": "iree/tools/test/BUILD"
    },
    {
      "type": "modify",
      "old_id": "bf6581f0422c889af174a7bf0a18d9490f28541c",
      "old_mode": 33188,
      "old_path": "iree/tools/test/CMakeLists.txt",
      "new_id": "aca8f33badbea954cc83f8b1262a2b7e72c8124d",
      "new_mode": 33188,
      "new_path": "iree/tools/test/CMakeLists.txt"
    }
  ]
}